Bug 89691 – [chromium] Move WebSerializedScriptValue into Platform and add forwarding header.

• Status: RESOLVED
• Resolution: WONTFIX
• Component: New Bugs

[Dave Tu]

[chromium] Move WebSerializedScriptValue into Platform and add forwarding header.

[Dave Tu]

Created attachment 148891 [details]
Patch

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[James Robinson]

Could you explain the dependency?  There don't appear to be any current uses of WebSerializedScriptValue in Platform, are you planning to add one?

[Dave Tu]

(In reply to comment #3)
> Could you explain the dependency?  There don't appear to be any current uses of WebSerializedScriptValue in Platform, are you planning to add one?

Yes, in WebRenderingStats.h in https://bugs.webkit.org/show_bug.cgi?id=88268

[Adam Barth]

Comment on attachment 148891 [details]
Patch

My initial reaction is that Platform shouldn't know anything about script.  Originally I thought it was unavoidable, but it seems avoidable so we should try to avoid it.

[Darin Fisher (:fishd, Google)]

(In reply to comment #5)
> (From update of attachment 148891 [details])
> My initial reaction is that Platform shouldn't know anything about script.  Originally I thought it was unavoidable, but it seems avoidable so we should try to avoid it.

+1

[Nat Duca]

We will manually serialize in chromium, I think. It sounds like our use case in rendering stats is a corner case rather than something commonplace. No worries, and thanks. :)