Bug 89684 - [Blackberry] BlackBerry::Platform::Settings::get() rename to BlackBerry::Platform::Settings::instance() to make it consistent with our other singletons
Summary: [Blackberry] BlackBerry::Platform::Settings::get() rename to BlackBerry::Plat...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Parth Patel
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-21 12:08 PDT by Parth Patel
Modified: 2012-06-22 09:24 PDT (History)
4 users (show)

See Also:

Attachments
Update setting instance access to use instance() instead of get(). (15.11 KB, patch)
2012-06-21 13:22 PDT, Parth Patel 		mifenton: review-
Details | Formatted Diff | Diff
Update setting instance access to use instance() instead of get(). (13.28 KB, patch)
2012-06-21 13:34 PDT, Parth Patel 		no flags Details | Formatted Diff | Diff
Build Fix-Typo Update setting instance access to use instance() instead of get(). (1.31 KB, patch)
2012-06-22 07:27 PDT, Parth Patel 		yong.li.webkit: review-
Details | Formatted Diff | Diff
Build Fix-Typo Update setting instance access to use instance() instead of get(). (2.29 KB, patch)
2012-06-22 07:34 PDT, Parth Patel 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Parth Patel 2012-06-21 12:08:39 PDT 
[Blackberry] BlackBerry::Platform::Settings::get() rename to BlackBerry::Platform::Settings::instance() to make it consistent with our other singletons
Comment 1 Parth Patel 2012-06-21 13:22:49 PDT 
Created attachment 148869 [details]
Update setting instance access to use instance() instead of get().

[Blackberry] BlackBerry::Platform::Settings::get() rename to BlackBerry::Platform::Settings::instance() to make it consistent with our other singletons
Comment 2 Mike Fenton 2012-06-21 13:25:26 PDT 
Comment on attachment 148869 [details]
Update setting instance access to use instance() instead of get().

Includes undesired change in WebCore
Comment 3 Parth Patel 2012-06-21 13:34:33 PDT 
Created attachment 148875 [details]
Update setting instance access to use instance() instead of get().

[Blackberry] BlackBerry::Platform::Settings::get() rename to BlackBerry::Platform::Settings::instance() to make it consistent with our other singletons
Comment 4 WebKit Review Bot 2012-06-21 18:20:08 PDT 
Comment on attachment 148875 [details]
Update setting instance access to use instance() instead of get().

Clearing flags on attachment: 148875

Committed r120987: <http://trac.webkit.org/changeset/120987>
Comment 5 WebKit Review Bot 2012-06-21 18:20:12 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Parth Patel 2012-06-22 07:27:10 PDT 
Created attachment 149022 [details]
Build Fix-Typo Update setting instance access to use instance() instead of get().

Typo error
Comment 7 Yong Li 2012-06-22 07:28:31 PDT 
Comment on attachment 149022 [details]
Build Fix-Typo Update setting instance access to use instance() instead of get().

Changelog missed?
Comment 8 Mike Fenton 2012-06-22 07:29:01 PDT 
Build Fix required.
Comment 9 Parth Patel 2012-06-22 07:34:06 PDT 
Created attachment 149023 [details]
Build Fix-Typo Update setting instance access to use instance() instead of get().

Build Fix Typo
Comment 10 WebKit Review Bot 2012-06-22 09:24:04 PDT 
Comment on attachment 149023 [details]
Build Fix-Typo Update setting instance access to use instance() instead of get().

Clearing flags on attachment: 149023

Committed r121029: <http://trac.webkit.org/changeset/121029>
Comment 11 WebKit Review Bot 2012-06-22 09:24:10 PDT 
All reviewed patches have been landed.  Closing bug.