Bug 89669 - Rename CSS Exclusions CSSWrapShape class properties to match Exclusion shape function parameters
Summary: Rename CSS Exclusions CSSWrapShape class properties to match Exclusion shape ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hans Muller
URL:
Keywords:
Depends on:
Blocks: 89671
  Show dependency tree / graph
 
Reported: 2012-06-21 09:31 PDT by Hans Muller
Modified: 2012-07-17 09:55 PDT (History)
5 users (show)

See Also:

Attachments
Patch (18.82 KB, patch)
2012-07-17 08:14 PDT, Hans Muller 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hans Muller 2012-06-21 09:31:01 PDT 
The names of a few of the CSSWrapShape class properties are inconsistent with the corresponding CSS shape function parameters: 

CSSWrapShapeRectangle - left,top should be x, y
CSSWrapShapeCircle - left,top should be centerX, centerY
CSSWrapShapeEllipse - left,top should be centerX, centerY

To precisely match the specification, radiusX,Y should be rx,y and centerX,Y should be cx,y.   This change doesn't seem helpful.
Comment 1 Hans Muller 2012-07-17 08:14:00 PDT 
Created attachment 152767 [details]
Patch
Comment 2 Dirk Schulze 2012-07-17 08:21:51 PDT 
Comment on attachment 152767 [details]
Patch

LGTM. r+
Comment 3 WebKit Review Bot 2012-07-17 09:55:10 PDT 
Comment on attachment 152767 [details]
Patch

Clearing flags on attachment: 152767

Committed r122848: <http://trac.webkit.org/changeset/122848>
Comment 4 WebKit Review Bot 2012-07-17 09:55:15 PDT 
All reviewed patches have been landed.  Closing bug.