Bug 89668 - Move CSSWrapShape style resolution from StyleResolver to StyleBuilder
Summary: Move CSSWrapShape style resolution from StyleResolver to StyleBuilder
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hans Muller
URL:
Keywords:
Depends on:
Blocks: 89671
  Show dependency treegraph
 
Reported: 2012-06-21 09:29 PDT by Hans Muller
Modified: 2012-06-29 17:41 PDT (History)
5 users (show)

See Also:


Attachments
Patch (5.98 KB, patch)
2012-06-21 10:02 PDT, Hans Muller
kling: review+
kling: commit-queue-
Details | Formatted Diff | Diff
patch with isShape condition (5.77 KB, patch)
2012-06-26 17:01 PDT, Bear Travis
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hans Muller 2012-06-21 09:29:44 PDT
All of the CSS Exclusions properties are handled by the StyleBuilder class, except for shapeInside and shapeOutside.  Move the implementation there, without changing the (current) semantics.
Comment 1 Hans Muller 2012-06-21 10:02:48 PDT
Created attachment 148827 [details]
Patch
Comment 2 Andreas Kling 2012-06-25 03:40:10 PDT
Comment on attachment 148827 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=148827&action=review

Looks good. r=me with one change:

> Source/WebCore/css/StyleBuilder.cpp:1782
> +            else
> +                setValue(styleResolver->style(), primitiveValue->getShapeValue());

The previous version of the code had a check for primitiveValue->isShape(), if we know that this should always be the case, we could put an ASSERT(primitiveValue->isShape()) here.
Comment 3 Bear Travis 2012-06-26 17:01:33 PDT
Created attachment 149636 [details]
patch with isShape condition

Trying to shepherd this through.

Eventually shape-inside / shape-outside will support a URI value referencing SVG content.
shape-inside will additionally support the value "shape-outside".
http://dev.w3.org/csswg/css3-exclusions/#shape-outside
http://dev.w3.org/csswg/css3-exclusions/#shape-inside

I added back the "isShape" condition, but did not add the assert, as we will eventually be supporting additional values.
Comment 4 WebKit Review Bot 2012-06-27 10:45:40 PDT
Comment on attachment 149636 [details]
patch with isShape condition

Clearing flags on attachment: 149636

Committed r121349: <http://trac.webkit.org/changeset/121349>
Comment 5 Bear Travis 2012-06-29 17:41:52 PDT
Closing the bug