Bug 89668 – Move CSSWrapShape style resolution from StyleResolver to StyleBuilder

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Hans Muller]

All of the CSS Exclusions properties are handled by the StyleBuilder class, except for shapeInside and shapeOutside.  Move the implementation there, without changing the (current) semantics.

[Hans Muller]

Created attachment 148827 [details]
Patch

[Andreas Kling]

Comment on attachment 148827 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=148827&action=review

Looks good. r=me with one change:

> Source/WebCore/css/StyleBuilder.cpp:1782
> +            else
> +                setValue(styleResolver->style(), primitiveValue->getShapeValue());

The previous version of the code had a check for primitiveValue->isShape(), if we know that this should always be the case, we could put an ASSERT(primitiveValue->isShape()) here.

[Bear Travis]

Created attachment 149636 [details]
patch with isShape condition

Trying to shepherd this through.

Eventually shape-inside / shape-outside will support a URI value referencing SVG content.
shape-inside will additionally support the value "shape-outside".
http://dev.w3.org/csswg/css3-exclusions/#shape-outside
http://dev.w3.org/csswg/css3-exclusions/#shape-inside

I added back the "isShape" condition, but did not add the assert, as we will eventually be supporting additional values.

[WebKit Review Bot]

Comment on attachment 149636 [details]
patch with isShape condition

Clearing flags on attachment: 149636

Committed r121349: <http://trac.webkit.org/changeset/121349>

[Bear Travis]

Closing the bug