WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
89655
[EFL] Simplify SharedBuffer::createWithContentsOfFile() implementation
https://bugs.webkit.org/show_bug.cgi?id=89655
Summary
[EFL] Simplify SharedBuffer::createWithContentsOfFile() implementation
Chris Dumez
Reported
2012-06-21 06:16:18 PDT
The EFL implementation of SharedBuffer::createWithContentsOfFile() could benefit from a slight simplification.
Attachments
Patch
(2.18 KB, patch)
2012-06-21 06:18 PDT
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Chris Dumez
Comment 1
2012-06-21 06:18:17 PDT
Created
attachment 148779
[details]
Patch
Raphael Kubo da Costa (:rakuco)
Comment 2
2012-06-21 11:27:10 PDT
Comment on
attachment 148779
[details]
Patch Looks nice, thanks for hunting down those C-isms.
Gyuyoung Kim
Comment 3
2012-06-21 20:00:03 PDT
Comment on
attachment 148779
[details]
Patch LGTM too. thanks.
Csaba Osztrogonác
Comment 4
2012-06-26 04:18:40 PDT
Comment on
attachment 148779
[details]
Patch rs=me
WebKit Review Bot
Comment 5
2012-06-26 05:11:15 PDT
Comment on
attachment 148779
[details]
Patch Clearing flags on attachment: 148779 Committed
r121254
: <
http://trac.webkit.org/changeset/121254
>
WebKit Review Bot
Comment 6
2012-06-26 05:11:20 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug