Bug 89655 - [EFL] Simplify SharedBuffer::createWithContentsOfFile() implementation
Summary: [EFL] Simplify SharedBuffer::createWithContentsOfFile() implementation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-21 06:16 PDT by Chris Dumez
Modified: 2012-06-26 05:11 PDT (History)
6 users (show)

See Also:

Attachments
Patch (2.18 KB, patch)
2012-06-21 06:18 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2012-06-21 06:16:18 PDT 
The EFL implementation of SharedBuffer::createWithContentsOfFile() could benefit from a slight simplification.
Comment 1 Chris Dumez 2012-06-21 06:18:17 PDT 
Created attachment 148779 [details]
Patch
Comment 2 Raphael Kubo da Costa (:rakuco) 2012-06-21 11:27:10 PDT 
Comment on attachment 148779 [details]
Patch

Looks nice, thanks for hunting down those C-isms.
Comment 3 Gyuyoung Kim 2012-06-21 20:00:03 PDT 
Comment on attachment 148779 [details]
Patch

LGTM too. thanks.
Comment 4 Csaba Osztrogonác 2012-06-26 04:18:40 PDT 
Comment on attachment 148779 [details]
Patch

rs=me
Comment 5 WebKit Review Bot 2012-06-26 05:11:15 PDT 
Comment on attachment 148779 [details]
Patch

Clearing flags on attachment: 148779

Committed r121254: <http://trac.webkit.org/changeset/121254>
Comment 6 WebKit Review Bot 2012-06-26 05:11:20 PDT 
All reviewed patches have been landed.  Closing bug.