Bug 89630 – REGRESSION(r120889): [Chromium] webkit_unit_tests didDrawNotCalledOnHiddenLayer start failing (Requested by ukai on #webkit).

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[WebKit Review Bot]

http://trac.webkit.org/changeset/120889 broke the build:
[Chromium] webkit_unit_tests didDrawNotCalledOnHiddenLayer start failing (Requested by ukai on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear

[WebKit Review Bot]

Created attachment 148708 [details]
ROLLOUT of r120889

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.

[Fumitoshi Ukai]

chromium.webkit WebKit Mac 10.6 (dbg)

[ RUN      ] CCLayerTreeHostImplTest.didDrawNotCalledOnHiddenLayer
ASSERTION FAILED: !HashTranslator::equal(KeyTraits::emptyValue(), key)
../../WTF/wtf/HashTable.h(498) : void WTF::HashTable
1   0x6c6e1659 void WTF::HashTable
2   0x6c6e1186 WTF::HashTableAddResult
3   0x6c6e103f WTF::HashMap
4   0x6c6df3a6 WTF::HashMap
5   0x6c6de1b2 WebCore::CCDamageTracker::saveRectForNextFrame(int, WebCore::FloatRect const&)
6   0x6c6de882 WebCore::CCDamageTracker::extendDamageForLayer(WebCore::CCLayerImpl*, WebCore::FloatRect&)
7   0x6c6ddc93 WebCore::CCDamageTracker::trackDamageFromActiveLayers(WTF::Vector<WebCore::CCLayerImpl*, 0ul> const&, int)
8   0x6c6dda50 WebCore::CCDamageTracker::updateDamageTrackingState(WTF::Vector<WebCore::CCLayerImpl*, 0ul> const&, int, bool, WebCore::IntRect const&, WebCore::CCLayerImpl*, WebKit::WebFilterOperations const&)
9   0x6c72aa59 WebCore::CCLayerTreeHostImpl::trackDamageForAllSurfaces(WebCore::CCLayerImpl*, WTF::Vector<WebCore::CCLayerImpl*, 0ul> const&)
10  0x6c72afa1 WebCore::CCLayerTreeHostImpl::calculateRenderSurfaceLayerList(WTF::Vector<WebCore::CCLayerImpl*, 0ul>&)
11  0x6c72b24f WebCore::CCLayerTreeHostImpl::calculateRenderPasses(WebCore::CCLayerTreeHostImpl::FrameData&)
12  0x6c72c59c WebCore::CCLayerTreeHostImpl::prepareToDraw(WebCore::CCLayerTreeHostImpl::FrameData&)
13  0x69cdd082 (anonymous namespace)::CCLayerTreeHostImplTest_didDrawNotCalledOnHiddenLayer_Test::TestBody()

http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Mac10.6%20%28dbg%29/builds/11106/steps/webkit_unit_tests/logs/stdio

chromium.webkit WebKit Mac 10.5 (dbg)(1) also failing
http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Mac10.5%20%28dbg%29%281%29/builds/8332/steps/webkit_unit_tests/logs/stdio

chromium.webkit WebKit Win (dbg) (1) also failing
http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Win%20%28dbg%29%281%29/builds/13202/steps/webkit_unit_tests/logs/stdio

chromium.webkit WebKit Linux (dbg) also failing
http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Linux%20%28dbg%29/builds/8254/steps/webkit_unit_tests/logs/stdio

[WebKit Review Bot]

Comment on attachment 148708 [details]
ROLLOUT of r120889

Clearing flags on attachment: 148708

Committed r120899: <http://trac.webkit.org/changeset/120899>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.