Bug 89628 - Make FormControlState capable to store multiple values
Summary: Make FormControlState capable to store multiple values
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kent Tamura
URL:
Keywords:
Depends on:
Blocks: 23346 89623 89847
  Show dependency treegraph
 
Reported: 2012-06-20 18:44 PDT by Kent Tamura
Modified: 2012-06-24 20:20 PDT (History)
6 users (show)

See Also:


Attachments
Patch (13.65 KB, patch)
2012-06-20 20:19 PDT, Kent Tamura
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Tamura 2012-06-20 18:44:55 PDT
FileInputType::saveFormControlState:

    // FIXME: FormControlState should be capable to have multiple strings and we
    // should stop the following ugly string concatenation.
    StringBuilder result;
    unsigned numFiles = m_fileList->length();
    for (unsigned i = 0; i < numFiles; ++i) {
        result.append(m_fileList->item(i)->path());
        result.append('\1');
        result.append(m_fileList->item(i)->name());
        result.append('\0');
    }

We resolve this FIXME in this bug.
Comment 1 Kent Tamura 2012-06-20 20:19:03 PDT
Created attachment 148719 [details]
Patch
Comment 2 WebKit Review Bot 2012-06-21 22:36:44 PDT
Comment on attachment 148719 [details]
Patch

Clearing flags on attachment: 148719

Committed r121004: <http://trac.webkit.org/changeset/121004>
Comment 3 WebKit Review Bot 2012-06-21 22:36:49 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Jessie Berlin 2012-06-22 09:49:32 PDT
(In reply to comment #2)
> (From update of attachment 148719 [details])
> Clearing flags on attachment: 148719
> 
> Committed r121004: <http://trac.webkit.org/changeset/121004>

This broke the i386 build:

Source/WebCore/html/FormController.cpp:62:36: error: implicit conversion loses integer precision: 'uint64_t' (aka 'unsigned long long') to 'size_t' (aka 'unsigned long') [-Werror,-Wshorten-64-to-32]
    state.m_values.reserveCapacity(valueSize);
    ~~~~~                          ^~~~~~~~~
Comment 5 David Kilzer (:ddkilzer) 2012-06-22 09:50:33 PDT
(In reply to comment #2)
> (From update of attachment 148719 [details])
> Clearing flags on attachment: 148719
> 
> Committed r121004: <http://trac.webkit.org/changeset/121004>

This caused a build failure on 32-bit architectures.  Follow-up build fix in r121032.

<http://trac.webkit.org/changeset/121032>
Comment 6 Kent Tamura 2012-06-24 17:30:01 PDT
(In reply to comment #5)
> > Committed r121004: <http://trac.webkit.org/changeset/121004>
> 
> This caused a build failure on 32-bit architectures.  Follow-up build fix in r121032.
> 
> <http://trac.webkit.org/changeset/121032>

Thank you for the fix!
We should have a 32 bit EWS.