Bug 89628 – Make FormControlState capable to store multiple values

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Kent Tamura]

FileInputType::saveFormControlState:

    // FIXME: FormControlState should be capable to have multiple strings and we
    // should stop the following ugly string concatenation.
    StringBuilder result;
    unsigned numFiles = m_fileList->length();
    for (unsigned i = 0; i < numFiles; ++i) {
        result.append(m_fileList->item(i)->path());
        result.append('\1');
        result.append(m_fileList->item(i)->name());
        result.append('\0');
    }

We resolve this FIXME in this bug.

[Kent Tamura]

Created attachment 148719 [details]
Patch

[WebKit Review Bot]

Comment on attachment 148719 [details]
Patch

Clearing flags on attachment: 148719

Committed r121004: <http://trac.webkit.org/changeset/121004>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Jessie Berlin]

(In reply to comment #2)
> (From update of attachment 148719 [details])
> Clearing flags on attachment: 148719
> 
> Committed r121004: <http://trac.webkit.org/changeset/121004>

This broke the i386 build:

Source/WebCore/html/FormController.cpp:62:36: error: implicit conversion loses integer precision: 'uint64_t' (aka 'unsigned long long') to 'size_t' (aka 'unsigned long') [-Werror,-Wshorten-64-to-32]
    state.m_values.reserveCapacity(valueSize);
    ~~~~~                          ^~~~~~~~~

[David Kilzer (:ddkilzer)]

(In reply to comment #2)
> (From update of attachment 148719 [details])
> Clearing flags on attachment: 148719
> 
> Committed r121004: <http://trac.webkit.org/changeset/121004>

This caused a build failure on 32-bit architectures.  Follow-up build fix in r121032.

<http://trac.webkit.org/changeset/121032>

[Kent Tamura]

(In reply to comment #5)
> > Committed r121004: <http://trac.webkit.org/changeset/121004>
> 
> This caused a build failure on 32-bit architectures.  Follow-up build fix in r121032.
> 
> <http://trac.webkit.org/changeset/121032>

Thank you for the fix!
We should have a 32 bit EWS.