RESOLVED FIXED 89627
run-perf-tests wrongly failure on win32 
https://bugs.webkit.org/show_bug.cgi?id=89627
Summary run-perf-tests wrongly failure on win32
Fumitoshi Ukai
Reported 2012-06-20 18:27:25 PDT
Tools/Scripts/run-perf-tests is expected not run on win32 platform (yet?), but Traceback (most recent call last): File "./Tools/Scripts/run-perf-tests", line 41, in <module> _log.error("run-perf-tests doesn't work on win32; needs webpagereplay support.") NameError: name '_log' is not defined Actually, it should log that message and exit 1. if sys.platform == 'win32': _log.error("run-perf-tests doesn't work on win32; needs webpagereplay su pport.") sys.exit(1) See http://build.webkit.org/builders/Chromium%20Win%20Release%20%28Perf%29/builds/2191/steps/perf-test/logs/stdio
Attachments
Add attachment proposed patch, testcase, etc.
Fumitoshi Ukai
Comment 1 2012-06-21 19:05:11 PDT
Fixed by http://trac.webkit.org/changeset/120965
Note You need to log in before you can comment on or make changes to this bug.