Bug 89626 - Non-fixed length margins don't work with align=center
Summary: Non-fixed length margins don't work with align=center
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Julien Chaffraix
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-20 18:26 PDT by Julien Chaffraix
Modified: 2012-06-21 10:15 PDT (History)
3 users (show)

See Also:


Attachments
Proposed fix 1. Use minimumValueForLength instead of Lengt::value. (7.79 KB, patch)
2012-06-20 19:25 PDT, Julien Chaffraix
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Julien Chaffraix 2012-06-20 18:26:15 PDT
Follow up of bug 89515, the attached bug nicely handled the fixed length case (100px) but it didn't handle non-fixed length (for example, calculated or percent) properly.

It turns out calling Length::value() on an arbitrary Length is not a good idea.

Patch forthcoming.
Comment 1 Julien Chaffraix 2012-06-20 19:25:26 PDT
Created attachment 148713 [details]
Proposed fix 1. Use minimumValueForLength instead of Lengt::value.
Comment 2 Levi Weintraub 2012-06-21 10:06:38 PDT
Comment on attachment 148713 [details]
Proposed fix 1. Use minimumValueForLength instead of Lengt::value.

Good catch! That certainly will not do.
Comment 3 WebKit Review Bot 2012-06-21 10:15:34 PDT
Comment on attachment 148713 [details]
Proposed fix 1. Use minimumValueForLength instead of Lengt::value.

Clearing flags on attachment: 148713

Committed r120934: <http://trac.webkit.org/changeset/120934>
Comment 4 WebKit Review Bot 2012-06-21 10:15:38 PDT
All reviewed patches have been landed.  Closing bug.