Bug 89609 – IndexedDB: Fix layout tests to clear previous database structures

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Joshua Bell]

IndexedDB: Fix layout tests to clear previous database structures

[Joshua Bell]

Created attachment 148671 [details]
Patch

[Joshua Bell]

tony@ - r?

[Tony Chang]

Comment on attachment 148671 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=148671&action=review

> LayoutTests/ChangeLog:10
> +        A handful of tests weren't deleting previously created stores (or the whole
> +        database), which made them fail if trivially re-run in Chromium or under
> +        NRWT with --iterations=2.

Should DRT delete all databases between tests?  See TestShell::resetTestController() where we reset other things Tools/DumpRenderTree/chromium/TestShell.cpp.

[Joshua Bell]

(In reply to comment #3)
> 
> Should DRT delete all databases between tests?  See TestShell::resetTestController() where we reset other things Tools/DumpRenderTree/chromium/TestShell.cpp.

Yes. I likely introduced this test-only regression with http://src.chromium.org/viewvc/chrome?view=rev&revision=140892 which stores the data on disk and persists it (via a temp dir) only for the lifetime of the WebIDBFactory instantiated via webKitPlatformSupport()->idbFactory() - but that factory should probably be discarded for each test run (and I had thought it was!).

[Joshua Bell]

FYI, changing out DRT uses temp dirs for IDB should be easier after https://bugs.webkit.org/show_bug.cgi?id=88338 lands.

[Joshua Bell]

Created attachment 148870 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 148870 [details]
Patch for landing

Clearing flags on attachment: 148870

Committed r120976: <http://trac.webkit.org/changeset/120976>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.