RESOLVED FIXED89601
Remove the warning "File not found" in MiniBrowser post-build event 
https://bugs.webkit.org/show_bug.cgi?id=89601
Summary Remove the warning "File not found" in MiniBrowser post-build event
Vivek Galatage
Reported 2012-06-20 13:50:12 PDT
Remove xcopy commands from MiniBrowser post-build script [D[Cas the files are obsolete
Attachments
Patch (3.48 KB, patch)
2012-06-20 13:53 PDT, Vivek Galatage 		no flags
DetailsFormatted DiffDiff
Patch (7.22 KB, patch)
2012-06-20 18:23 PDT, Vivek Galatage 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Vivek Galatage
Comment 1 2012-06-20 13:53:29 PDT
Created attachment 148649 [details] Patch
Vivek Galatage
Comment 2 2012-06-20 13:54:46 PDT
Performing Post-Build Event... File not found - CoreFoundation.dll 0 File(s) copied File not found - CoreFoundation.pdb 0 File(s) copied File not found - CFNetwork.dll 0 File(s) copied File not found - CFNetwork.pdb 0 File(s) copied File not found - CFNetwork.resources 0 File(s) copied File not found - CoreFoundation.resources 0 File(s) copied File not found - CoreGraphics.dll 0 File(s) copied File not found - CoreGraphics.pdb 0 File(s) copied File not found - icuin40.dll 0 File(s) copied File not found - icuin40.pdb 0 File(s) copied File not found - icuuc40.dll 0 File(s) copied File not found - icuuc40.pdb 0 File(s) copied File not found - libxml2.dll 0 File(s) copied File not found - libxslt.dll 0 File(s) copied File not found - pthreadVC2.dll 0 File(s) copied File not found - pthreadVC2.pdb 0 File(s) copied File not found - SQLite3.dll 0 File(s) copied File not found - SQLite3.pdb 0 File(s) copied File not found - zlib1.dll 0 File(s) copied File not found - zlib1.pdb 0 File(s) copied File not found - objc.dll 0 File(s) copied File not found - objc.pdb 0 File(s) copied
Vivek Galatage
Comment 3 2012-06-20 13:55:42 PDT
Removed all the xcopy commands as everything reports file not found.
Adam Roben (:aroben)
Comment 4 2012-06-20 14:08:23 PDT
Comment on attachment 148649 [details] Patch These files are present for Apple-internal builds. Sorry the script doesn't make that clearer.
Vivek Galatage
Comment 5 2012-06-20 14:15:58 PDT
(In reply to comment #4) > (From update of attachment 148649 [details]) > These files are present for Apple-internal builds. Sorry the script doesn't make that clearer. Ah ok. Didn't know that. So are these files missing even on build bots? I see the bots also report the error. http://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/32028/steps/compile-webkit/logs/stdio
Vivek Galatage
Comment 6 2012-06-20 18:23:46 PDT
Created attachment 148699 [details] Patch
Vivek Galatage
Comment 7 2012-06-20 18:24:09 PDT
Adding the condition to check if the files exist and only then issuing xcopy to copy them to destination. This way it will preserve copying on apple internal builds while removing the warning for others.
Adam Roben (:aroben)
Comment 8 2012-06-21 05:23:15 PDT
Comment on attachment 148699 [details] Patch Looks great! By the way, there are other post-build events that do the same thing (DumpRenderTree and WebKitTestRunner, I think?).
WebKit Review Bot
Comment 9 2012-06-21 05:28:09 PDT
Comment on attachment 148699 [details] Patch Clearing flags on attachment: 148699 Committed r120920: <http://trac.webkit.org/changeset/120920>
WebKit Review Bot
Comment 10 2012-06-21 05:28:14 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.