Bug 89601 - Remove the warning "File not found" in MiniBrowser post-build event
Summary: Remove the warning "File not found" in MiniBrowser post-build event
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Vivek Galatage
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-20 13:50 PDT by Vivek Galatage
Modified: 2012-06-21 05:28 PDT (History)
2 users (show)

See Also:


Attachments
Patch (3.48 KB, patch)
2012-06-20 13:53 PDT, Vivek Galatage
no flags Details | Formatted Diff | Diff
Patch (7.22 KB, patch)
2012-06-20 18:23 PDT, Vivek Galatage
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vivek Galatage 2012-06-20 13:50:12 PDT
Remove xcopy commands from MiniBrowser post-build script [D[Cas the files are obsolete
Comment 1 Vivek Galatage 2012-06-20 13:53:29 PDT
Created attachment 148649 [details]
Patch
Comment 2 Vivek Galatage 2012-06-20 13:54:46 PDT
Performing Post-Build Event...
File not found - CoreFoundation.dll
0 File(s) copied
File not found - CoreFoundation.pdb
0 File(s) copied
File not found - CFNetwork.dll
0 File(s) copied
File not found - CFNetwork.pdb
0 File(s) copied
File not found - CFNetwork.resources
0 File(s) copied
File not found - CoreFoundation.resources
0 File(s) copied
File not found - CoreGraphics.dll
0 File(s) copied
File not found - CoreGraphics.pdb
0 File(s) copied
File not found - icuin40.dll
0 File(s) copied
File not found - icuin40.pdb
0 File(s) copied
File not found - icuuc40.dll
0 File(s) copied
File not found - icuuc40.pdb
0 File(s) copied
File not found - libxml2.dll
0 File(s) copied
File not found - libxslt.dll
0 File(s) copied
File not found - pthreadVC2.dll
0 File(s) copied
File not found - pthreadVC2.pdb
0 File(s) copied
File not found - SQLite3.dll
0 File(s) copied
File not found - SQLite3.pdb
0 File(s) copied
File not found - zlib1.dll
0 File(s) copied
File not found - zlib1.pdb
0 File(s) copied
File not found - objc.dll
0 File(s) copied
File not found - objc.pdb
0 File(s) copied
Comment 3 Vivek Galatage 2012-06-20 13:55:42 PDT
Removed all the xcopy commands as everything reports file not found.
Comment 4 Adam Roben (:aroben) 2012-06-20 14:08:23 PDT
Comment on attachment 148649 [details]
Patch

These files are present for Apple-internal builds. Sorry the script doesn't make that clearer.
Comment 5 Vivek Galatage 2012-06-20 14:15:58 PDT
(In reply to comment #4)
> (From update of attachment 148649 [details])
> These files are present for Apple-internal builds. Sorry the script doesn't make that clearer.

Ah ok. Didn't know that. So are these files missing even on build bots? I see the bots also report the error. http://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/32028/steps/compile-webkit/logs/stdio
Comment 6 Vivek Galatage 2012-06-20 18:23:46 PDT
Created attachment 148699 [details]
Patch
Comment 7 Vivek Galatage 2012-06-20 18:24:09 PDT
Adding the condition to check if the files exist and only then issuing xcopy to copy them to destination. This way it will preserve copying on apple internal builds while removing the warning for others.
Comment 8 Adam Roben (:aroben) 2012-06-21 05:23:15 PDT
Comment on attachment 148699 [details]
Patch

Looks great! By the way, there are other post-build events that do the same thing (DumpRenderTree and WebKitTestRunner, I think?).
Comment 9 WebKit Review Bot 2012-06-21 05:28:09 PDT
Comment on attachment 148699 [details]
Patch

Clearing flags on attachment: 148699

Committed r120920: <http://trac.webkit.org/changeset/120920>
Comment 10 WebKit Review Bot 2012-06-21 05:28:14 PDT
All reviewed patches have been landed.  Closing bug.