Bug 89595 - [BlackBerry] Input mode should adapt automatically to settings changes
Summary: [BlackBerry] Input mode should adapt automatically to settings changes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mike Fenton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-20 12:53 PDT by Mike Fenton
Modified: 2012-06-21 06:40 PDT (History)
2 users (show)

See Also:

Attachments
Patch (10.13 KB, patch)
2012-06-20 13:45 PDT, Mike Fenton 		tonikitoo: review+
Details | Formatted Diff | Diff
Updated patch based on suggestion. (10.12 KB, patch)
2012-06-21 05:56 PDT, Mike Fenton 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Fenton 2012-06-20 12:53:54 PDT 
Currently the input mode is overridden when being set based on settings, this should happen immediately and not wait for a set call to update.
Comment 1 Mike Fenton 2012-06-20 13:45:28 PDT 
Created attachment 148648 [details]
Patch
Comment 2 Antonio Gomes 2012-06-20 13:51:34 PDT 
Comment on attachment 148648 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=148648&action=review

I think I like the name isInputMethodEnabled more. Up to you...

> Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:435
> +bool InputHandler::inputModeEnabled()

const?
Comment 3 Mike Fenton 2012-06-21 05:56:09 PDT 
Created attachment 148776 [details]
Updated patch based on suggestion.
Comment 4 WebKit Review Bot 2012-06-21 06:40:01 PDT 
Comment on attachment 148776 [details]
Updated patch based on suggestion.

Clearing flags on attachment: 148776

Committed r120923: <http://trac.webkit.org/changeset/120923>
Comment 5 WebKit Review Bot 2012-06-21 06:40:05 PDT 
All reviewed patches have been landed.  Closing bug.