RESOLVED FIXED 89595
[BlackBerry] Input mode should adapt automatically to settings changes 
https://bugs.webkit.org/show_bug.cgi?id=89595
Summary [BlackBerry] Input mode should adapt automatically to settings changes
Mike Fenton
Reported 2012-06-20 12:53:54 PDT
Currently the input mode is overridden when being set based on settings, this should happen immediately and not wait for a set call to update.
Attachments
Patch (10.13 KB, patch)
2012-06-20 13:45 PDT, Mike Fenton 		tonikitoo: review+
DetailsFormatted DiffDiff
Updated patch based on suggestion. (10.12 KB, patch)
2012-06-21 05:56 PDT, Mike Fenton 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mike Fenton
Comment 1 2012-06-20 13:45:28 PDT
Created attachment 148648 [details] Patch
Antonio Gomes
Comment 2 2012-06-20 13:51:34 PDT
Comment on attachment 148648 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=148648&action=review I think I like the name isInputMethodEnabled more. Up to you... > Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:435 > +bool InputHandler::inputModeEnabled() const?
Mike Fenton
Comment 3 2012-06-21 05:56:09 PDT
Created attachment 148776 [details] Updated patch based on suggestion.
WebKit Review Bot
Comment 4 2012-06-21 06:40:01 PDT
Comment on attachment 148776 [details] Updated patch based on suggestion. Clearing flags on attachment: 148776 Committed r120923: <http://trac.webkit.org/changeset/120923>
WebKit Review Bot
Comment 5 2012-06-21 06:40:05 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.