Bug 89592 – Web Inspector: [WebGL] Add injected WebGL module class

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Andrey Adaikin]

Adding a new InjectedScriptWebGLModule class and moving WebGL-related stuff out of InjectedScriptManager class.

[Andrey Adaikin]

Created attachment 148624 [details]
Patch

[Pavel Feldman]

Comment on attachment 148624 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=148624&action=review

> Source/WebCore/inspector/InjectedScriptWebGLModule.cpp:46
> +    : InjectedScriptModule("InjectedScriptWebGLModule")

"webgl"?

[WebKit Review Bot]

Comment on attachment 148624 [details]
Patch

Rejecting attachment 148624 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
anager.h
patching file Source/WebCore/inspector/InjectedScriptModule.cpp
patching file Source/WebCore/inspector/InjectedScriptModule.h
patching file Source/WebCore/inspector/InjectedScriptWebGLModule.cpp
patching file Source/WebCore/inspector/InjectedScriptWebGLModule.h
patching file Source/WebCore/inspector/InspectorWebGLAgent.cpp

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Pavel Feld..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/13012097

[Andrey Adaikin]

Created attachment 148727 [details]
Rebased patch to land

[Andrey Adaikin]

Comment on attachment 148624 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=148624&action=review

>> Source/WebCore/inspector/InjectedScriptWebGLModule.cpp:46
>> +    : InjectedScriptModule("InjectedScriptWebGLModule")
> 
> "webgl"?

For InjectedScript it was "InjectedScript". This string will be also passed into the InspectorInstrumentation::willCallFunction() method.

[Yury Semikhatsky]

Comment on attachment 148727 [details]
Rebased patch to land

View in context: https://bugs.webkit.org/attachment.cgi?id=148727&action=review

> Source/WebCore/inspector/InjectedScriptWebGLModule.h:49
> +    static InjectedScriptWebGLModule injectedModuleForState(InjectedScriptManager*, ScriptState*);

ensureModuleInjectedForState or simply moduleForState?

> Source/WebCore/inspector/InspectorWebGLAgent.cpp:100
> +    ASSERT(!glContext.hasNoValue());

Put ASSERT_NOT_REACHED() in the if block below instead.

> Source/WebCore/inspector/InspectorWebGLAgent.cpp:105
> +    if (module.hasNoValue())

Put ASSERT_NOT_REACHED() in the if block below instead.

[Andrey Adaikin]

Comment on attachment 148727 [details]
Rebased patch to land

View in context: https://bugs.webkit.org/attachment.cgi?id=148727&action=review

>> Source/WebCore/inspector/InjectedScriptWebGLModule.h:49
>> +    static InjectedScriptWebGLModule injectedModuleForState(InjectedScriptManager*, ScriptState*);
> 
> ensureModuleInjectedForState or simply moduleForState?

renamed to moduleForState

>> Source/WebCore/inspector/InspectorWebGLAgent.cpp:100
>> +    ASSERT(!glContext.hasNoValue());
> 
> Put ASSERT_NOT_REACHED() in the if block below instead.

Done.

>> Source/WebCore/inspector/InspectorWebGLAgent.cpp:105
>> +    if (module.hasNoValue())
> 
> Put ASSERT_NOT_REACHED() in the if block below instead.

Done.

[Andrey Adaikin]

Created attachment 148813 [details]
Patch to land

[WebKit Review Bot]

Comment on attachment 148813 [details]
Patch to land

Clearing flags on attachment: 148813

Committed r120929: <http://trac.webkit.org/changeset/120929>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.