Bug 89583 – BlackBerry port does not sanitize GLSL code with ANGLE

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit BlackBerry

[Joshua Netterfield]

The BlackBerry port does not sanitize GLSL code with ANGLE like all other ports.

It should.

[Joshua Netterfield]

Created attachment 148616 [details]
Patch

[Joshua Netterfield]

Created attachment 148619 [details]
Patch

[Konrad Piascik]

Comment on attachment 148619 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=148619&action=review

I don't know enough about the affected files to provide a full review but these style issues should be fixed.

> Source/ThirdParty/ANGLE/ChangeLog:8
> +        Reviewed by NOBODY (OOPS!).

you need to specify what changes were made.  The bug title is not descriptive enough to describe what changes are needed in all these files.

> Source/WebCore/ChangeLog:8
> +        Reviewed by NOBODY (OOPS!).

ditto

> Source/WebKit/ChangeLog:8
> +        Reviewed by NOBODY (OOPS!).

ditto

> Source/WebCore/platform/graphics/GraphicsContext3D.h:82
> +#if (PLATFORM(CHROMIUM) && USE(SKIA))

There shouldn't be a need to add these brackets

> ChangeLog:8
> +        Reviewed by NOBODY (OOPS!).

ditto

[Joshua Netterfield]

Created attachment 148856 [details]
Patch

[Konrad Piascik]

Comment on attachment 148856 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=148856&action=review

> Source/WebCore/CMakeLists.txt:-2325
> -        ${THIRDPARTY_DIR}/ANGLE/src/compiler/preprocessor/atom.c

why did you move these files lower? Alpha order seems to be case insensitive in this list.

> ChangeLog:10
> +        * Source/cmake/OptionsBlackBerry.cmake:

need description of change

[Joshua Netterfield]

Created attachment 148862 [details]
Patch

[Konrad Piascik]

The patch looks good to me but I'd rather have someone who's more familiar with WebGL review this to make sure that we're not breaking anything, both on our port and for everyone else.

[Rob Buis]

Comment on attachment 148862 [details]
Patch

Looks good.

[WebKit Review Bot]

Comment on attachment 148862 [details]
Patch

Clearing flags on attachment: 148862

Committed r121051: <http://trac.webkit.org/changeset/121051>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.