Bug 89578 - [CSS Shaders] Rename CustomFilterShader class name to CustomFilterCompiledProgram
Summary: [CSS Shaders] Rename CustomFilterShader class name to CustomFilterCompiledPro...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexandru Chiculita
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-20 10:01 PDT by Alexandru Chiculita
Modified: 2012-06-20 18:14 PDT (History)
3 users (show)

See Also:


Attachments
Patch V1 (42.67 KB, patch)
2012-06-20 16:58 PDT, Alexandru Chiculita
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexandru Chiculita 2012-06-20 10:01:17 PDT
We have two classes that have similar name:
1. CustomFilterProgram - base class of the StyleCustomFilterProgram class which keeps references to the CSS Shaders
2. CustomFilterShader - object created as a result of compiling a CustomFilterProgram.

I suppose that CustomFilterShader can be changed to CustomFilterCompiledProgram to better show the link to the CustomFilterProgram and the fact that it stores the precompiled shader.
Comment 1 Alexandru Chiculita 2012-06-20 16:58:04 PDT
Created attachment 148682 [details]
Patch V1
Comment 2 Dean Jackson 2012-06-20 17:05:40 PDT
Comment on attachment 148682 [details]
Patch V1

rs=me
Comment 3 WebKit Review Bot 2012-06-20 18:14:14 PDT
Comment on attachment 148682 [details]
Patch V1

Clearing flags on attachment: 148682

Committed r120893: <http://trac.webkit.org/changeset/120893>
Comment 4 WebKit Review Bot 2012-06-20 18:14:19 PDT
All reviewed patches have been landed.  Closing bug.