WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
89578
[CSS Shaders] Rename CustomFilterShader class name to CustomFilterCompiledProgram
https://bugs.webkit.org/show_bug.cgi?id=89578
Summary
[CSS Shaders] Rename CustomFilterShader class name to CustomFilterCompiledPro...
Alexandru Chiculita
Reported
2012-06-20 10:01:17 PDT
We have two classes that have similar name: 1. CustomFilterProgram - base class of the StyleCustomFilterProgram class which keeps references to the CSS Shaders 2. CustomFilterShader - object created as a result of compiling a CustomFilterProgram. I suppose that CustomFilterShader can be changed to CustomFilterCompiledProgram to better show the link to the CustomFilterProgram and the fact that it stores the precompiled shader.
Attachments
Patch V1
(42.67 KB, patch)
2012-06-20 16:58 PDT
,
Alexandru Chiculita
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Alexandru Chiculita
Comment 1
2012-06-20 16:58:04 PDT
Created
attachment 148682
[details]
Patch V1
Dean Jackson
Comment 2
2012-06-20 17:05:40 PDT
Comment on
attachment 148682
[details]
Patch V1 rs=me
WebKit Review Bot
Comment 3
2012-06-20 18:14:14 PDT
Comment on
attachment 148682
[details]
Patch V1 Clearing flags on attachment: 148682 Committed
r120893
: <
http://trac.webkit.org/changeset/120893
>
WebKit Review Bot
Comment 4
2012-06-20 18:14:19 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug