RESOLVED FIXED89563
DRT/WTR python interface handles about:blank incorrectly 
https://bugs.webkit.org/show_bug.cgi?id=89563
Summary DRT/WTR python interface handles about:blank incorrectly
Zoltan Horvath
Reported 2012-06-20 06:23:30 PDT
WPR loads about:blank before every page load. In the case of loading about:blank we should not wait longer than 1 sec.
Attachments
proposed patch (1.45 KB, patch)
2012-06-20 06:25 PDT, Zoltan Horvath 		no flags
DetailsFormatted DiffDiff
proposed patch (1.59 KB, patch)
2012-06-21 12:45 PDT, Zoltan Horvath 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zoltan Horvath
Comment 1 2012-06-20 06:25:21 PDT
Created attachment 148549 [details] proposed patch
Ryosuke Niwa
Comment 2 2012-06-20 10:03:58 PDT
Why is this necessary? about:blank should be loaded in a few milliseconds, no?
Alexey Proskuryakov
Comment 3 2012-06-20 10:20:06 PDT
What is "WPR"?
Zoltan Horvath
Comment 4 2012-06-20 10:40:56 PDT
(In reply to comment #2) > Why is this necessary? about:blank should be loaded in a few milliseconds, no? On Qt's side server_process.py:217 (select.select(select_fds, [], select_fds, deadline - time.time())) hangs until the timeout ends what is 10 minutes by default. (In reply to comment #3) > What is "WPR"? Web Page Reply
Zoltan Horvath
Comment 5 2012-06-20 10:41:12 PDT
Web Page Replay
Ryosuke Niwa
Comment 6 2012-06-20 11:41:33 PDT
(In reply to comment #4) > (In reply to comment #2) > > Why is this necessary? about:blank should be loaded in a few milliseconds, no? > > On Qt's side server_process.py:217 (select.select(select_fds, [], select_fds, deadline - time.time())) hangs until the timeout ends what is 10 minutes by default. !? That sounds like a bug of its own. We should fix that instead.
Zoltan Horvath
Comment 7 2012-06-20 13:45:56 PDT
(In reply to comment #6) > > !? That sounds like a bug of its own. We should fix that instead. Right! I might need some help. Could you check me two things on your port? 1. output of "DumpRenderTree about:blank" 2. webkitpy/layout_tests/port/webkit.py:564, please print command and share the first result with me (it will be about:blank somehow, for me it's /home/zoltan/prog/local/WebKit/LayoutTests/about:blank) I'm trying to figure out the problem related to Qt-port.
Zoltan Horvath
Comment 8 2012-06-21 05:59:55 PDT
I have the proper fix, I will upload and modify the patch later today.
Zoltan Horvath
Comment 9 2012-06-21 12:45:42 PDT
Created attachment 148867 [details] proposed patch Currently DRT/WTR python interface's _command_from_driver_input function puts the test directory path before about:blank. Remove this incorrect behavior. e.g. /home/zoltan/prog/local/WebKit/LayoutTests/about:blank Let it just use about:blank. :)
WebKit Review Bot
Comment 10 2012-06-21 16:32:20 PDT
Comment on attachment 148867 [details] proposed patch Clearing flags on attachment: 148867 Committed r120977: <http://trac.webkit.org/changeset/120977>
WebKit Review Bot
Comment 11 2012-06-21 16:32:25 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.