Bug 89563 - DRT/WTR python interface handles about:blank incorrectly
Summary: DRT/WTR python interface handles about:blank incorrectly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zoltan Horvath
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-20 06:23 PDT by Zoltan Horvath
Modified: 2012-06-21 16:32 PDT (History)
6 users (show)

See Also:

Attachments
proposed patch (1.45 KB, patch)
2012-06-20 06:25 PDT, Zoltan Horvath 		no flags Details | Formatted Diff | Diff
proposed patch (1.59 KB, patch)
2012-06-21 12:45 PDT, Zoltan Horvath 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zoltan Horvath 2012-06-20 06:23:30 PDT 
WPR loads about:blank before every page load. In the case of loading about:blank we should not wait longer than 1 sec.
Comment 1 Zoltan Horvath 2012-06-20 06:25:21 PDT 
Created attachment 148549 [details]
proposed patch
Comment 2 Ryosuke Niwa 2012-06-20 10:03:58 PDT 
Why is this necessary? about:blank should be loaded in a few milliseconds, no?
Comment 3 Alexey Proskuryakov 2012-06-20 10:20:06 PDT 
What is "WPR"?
Comment 4 Zoltan Horvath 2012-06-20 10:40:56 PDT 
(In reply to comment #2)
> Why is this necessary? about:blank should be loaded in a few milliseconds, no?

On Qt's side server_process.py:217 (select.select(select_fds, [], select_fds, deadline - time.time())) hangs until the timeout ends what is 10 minutes by default.

(In reply to comment #3)
> What is "WPR"?

Web Page Reply
Comment 5 Zoltan Horvath 2012-06-20 10:41:12 PDT 
Web Page Replay
Comment 6 Ryosuke Niwa 2012-06-20 11:41:33 PDT 
(In reply to comment #4)
> (In reply to comment #2)
> > Why is this necessary? about:blank should be loaded in a few milliseconds, no?
> 
> On Qt's side server_process.py:217 (select.select(select_fds, [], select_fds, deadline - time.time())) hangs until the timeout ends what is 10 minutes by default.

!? That sounds like a bug of its own. We should fix that instead.
Comment 7 Zoltan Horvath 2012-06-20 13:45:56 PDT 
(In reply to comment #6)
>
> !? That sounds like a bug of its own. We should fix that instead.

Right! I might need some help. Could you check me two things on your port?

1. output of "DumpRenderTree about:blank"
2. webkitpy/layout_tests/port/webkit.py:564, please print command and share the first result with me (it will be about:blank somehow, for me it's /home/zoltan/prog/local/WebKit/LayoutTests/about:blank)

I'm trying to figure out the problem related to Qt-port.
Comment 8 Zoltan Horvath 2012-06-21 05:59:55 PDT 
I have the proper fix, I will upload and modify the patch later today.
Comment 9 Zoltan Horvath 2012-06-21 12:45:42 PDT 
Created attachment 148867 [details]
proposed patch

Currently DRT/WTR python interface's _command_from_driver_input function puts the test directory path before about:blank. Remove this incorrect behavior.

e.g. /home/zoltan/prog/local/WebKit/LayoutTests/about:blank

Let it just use about:blank. :)
Comment 10 WebKit Review Bot 2012-06-21 16:32:20 PDT 
Comment on attachment 148867 [details]
proposed patch

Clearing flags on attachment: 148867

Committed r120977: <http://trac.webkit.org/changeset/120977>
Comment 11 WebKit Review Bot 2012-06-21 16:32:25 PDT 
All reviewed patches have been landed.  Closing bug.