Bug 89559 – Web Inspector: duplicating selected text when Enter key is pressed.

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Sergey Rogulenko]

If you open a file in Sources in inspector, select some text from bottom to top(!) and press Enter key, the selected text will not substitute with one new line. Also, if you try to undo this action, the respond will not bring you to initial state.

[Sergey Rogulenko]

Created attachment 148546 [details]
Patch

[Pavel Feldman]

Comment on attachment 148546 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=148546&action=review

> Source/WebCore/ChangeLog:3
> +        Fixing Bug 89559 - Web Inspector: handling enter key bug

Patch should start with the bug title.

> Source/WebCore/ChangeLog:5
> +        Web Inspector: handling enter key bug

This bug title is too vague, please be more specific

> Source/WebCore/ChangeLog:12
> +        The person who fixed Bug 71625 forgot to use result of his own method.

We typically say "Regressed in rXXXX" where XXXX is a revision number. That should be mentioned in the bug description.

> Source/WebCore/inspector/front-end/TextViewer.js:1254
>          this._exitTextChangeMode(range, newRange);

You should call exitTextChangeMode with exact newRange that editRange returned.

[Sergey Rogulenko]

Created attachment 148566 [details]
Patch

[WebKit Review Bot]

Comment on attachment 148566 [details]
Patch

Clearing flags on attachment: 148566

Committed r120827: <http://trac.webkit.org/changeset/120827>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.