Bug 89558 – [WK2] Add support for Battery Status API

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Chris Dumez]

There is currently no support for the Battery Status API in WebKit 2, we need to bring support for it.

[Chris Dumez]

Created attachment 148544 [details]
Patch

The ews-mac probably won't be happy because I haven't added the new files to the XCode project yet (I don't have a mac machine available at the moment).
The C APIs for WKBatteryManager and WKBatteryStatus are not included in this patch and will be provided separately to reduce patch size.

[Early Warning System Bot]

Comment on attachment 148544 [details]
Patch

Attachment 148544 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/13006178

[Build Bot]

Comment on attachment 148544 [details]
Patch

Attachment 148544 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/13002189

[Chris Dumez]

Created attachment 148548 [details]
Patch

Attempt to fix Qt, GTK and Win build.

[Gustavo Noronha (kov)]

Comment on attachment 148548 [details]
Patch

Attachment 148548 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/12999184

[Build Bot]

Comment on attachment 148548 [details]
Patch

Attachment 148548 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/13002196

[Early Warning System Bot]

Comment on attachment 148548 [details]
Patch

Attachment 148548 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/12999191

[Build Bot]

Comment on attachment 148548 [details]
Patch

Attachment 148548 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/13003195

[Chris Dumez]

Created attachment 148576 [details]
Patch

[Chris Dumez]

Created attachment 148584 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 148584 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=148584&action=review

> Source/WebKit2/UIProcess/API/C/WKBatteryManager.h:29
> +#if ENABLE(BATTERY_STATUS)

As I mentioned in other bugs, I'm not sure if ENABLE(...) still can be used in WK header files. WK header files have not used ENABLE(...) except for ENABLE(INSPECTOR).

[Chris Dumez]

Created attachment 148734 [details]
Patch

Take Gyuyoung's feedback into consideration.

[Kenneth Rohde Christiansen]

Comment on attachment 148734 [details]
Patch

LGTM

[Gyuyoung Kim]

Comment on attachment 148734 [details]
Patch

Looks fine too.

[WebKit Review Bot]

Comment on attachment 148734 [details]
Patch

Rejecting attachment 148734 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
t/git/webkit-commit-queue/Source/WebKit/chromium/v8 --revision 11978 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
47>At revision 11978.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/13126546

[Chris Dumez]

Comment on attachment 148734 [details]
Patch

Error is "Could not resolve hostname `svn.webkit.org'". Seems unrelated so resetting cq flag.

[WebKit Review Bot]

Comment on attachment 148734 [details]
Patch

Clearing flags on attachment: 148734

Committed r121808: <http://trac.webkit.org/changeset/121808>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.