Bug 89538 - [GTK] [WebKit1] Schedule next 60FPS sync before rendering contents to the window in AcceleratedCompositingContextGL
Summary: [GTK] [WebKit1] Schedule next 60FPS sync before rendering contents to the win...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Changwan Hong
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-19 18:11 PDT by Changwan Hong
Modified: 2012-06-19 22:51 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.02 KB, patch)
2012-06-19 18:12 PDT, Changwan Hong 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Changwan Hong 2012-06-19 18:11:49 PDT 
Refine syncLayersTimeoutCallback for Accelerated Compositing.
Comment 1 Changwan Hong 2012-06-19 18:12:13 PDT 
Created attachment 148478 [details]
Patch
Comment 2 Martin Robinson 2012-06-19 20:13:29 PDT 
Comment on attachment 148478 [details]
Patch

Does this have some observable change in behavior?
Comment 3 Changwan Hong 2012-06-19 21:06:52 PDT 
(In reply to comment #2)
> (From update of attachment 148478 [details])
> Does this have some observable change in behavior?

If rendering takes long time (Contents are complex or performance of hardware is low like as embedded system), it delays timer so it can not draw in correct time.
Comment 4 Martin Robinson 2012-06-19 21:30:18 PDT 
(In reply to comment #3)

> If rendering takes long time (Contents are complex or performance of hardware is low like as embedded system), it delays timer so it can not draw in correct time.

I guess what I mean is are you actually seeing this happen?
Comment 5 Changwan Hong 2012-06-19 21:38:06 PDT 
(In reply to comment #4)
> (In reply to comment #3)
> 
> > If rendering takes long time (Contents are complex or performance of hardware is low like as embedded system), it delays timer so it can not draw in correct time.
> 
> I guess what I mean is are you actually seeing this happen?

Yes. I saw that. I tested it on Exynos.
Comment 6 WebKit Review Bot 2012-06-19 22:51:24 PDT 
Comment on attachment 148478 [details]
Patch

Clearing flags on attachment: 148478

Committed r120803: <http://trac.webkit.org/changeset/120803>
Comment 7 WebKit Review Bot 2012-06-19 22:51:29 PDT 
All reviewed patches have been landed.  Closing bug.