Bug 89532 – [V8] Fix issue where a callback got a null calling context

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Erik Arvidsson]

[V8] Fix issue where a callback got a null calling context

[Erik Arvidsson]

Created attachment 148459 [details]
Patch

[Erik Arvidsson]

See http://code.google.com/p/chromium/issues/detail?id=130462 for more details

[Kentaro Hara]

Comment on attachment 148459 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=148459&action=review

The change looks OK.

> Source/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp:309
> +        return V8Proxy::throwTypeError(0, args.GetIsolate());

0 will output "Type error". What error message does JSC throw? (We want to keep the error message consistent between JSC and V8.)

[Erik Arvidsson]

(In reply to comment #3)
> (From update of attachment 148459 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=148459&action=review
> 
> The change looks OK.
> 
> > Source/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp:309
> > +        return V8Proxy::throwTypeError(0, args.GetIsolate());
> 
> 0 will output "Type error". What error message does JSC throw? (We want to keep the error message consistent between JSC and V8.)

Yup. I wanted to use 0 to match JSC.

[Kentaro Hara]

Comment on attachment 148459 [details]
Patch

Thanks for the clarification.

[WebKit Review Bot]

Comment on attachment 148459 [details]
Patch

Clearing flags on attachment: 148459

Committed r120783: <http://trac.webkit.org/changeset/120783>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.