Bug 89524 - [Mac] Dismiss the Geolocation permission dialog in response to GeolocationClient::cancelPermissionRequest()
Summary: [Mac] Dismiss the Geolocation permission dialog in response to GeolocationCli...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-19 16:17 PDT by Benjamin Poulain
Modified: 2012-06-19 16:17 PDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2012-06-19 16:17:08 PDT 
On WebKit1, the Geolocation permission query is not cancelled on cancelPermissionRequest:
   virtual void cancelPermissionRequest(WebCore::Geolocation*) OVERRIDE { };    (in WebGeolocationClient.h) 

The problem is we can have the WebKit layers calling Geolocation::setIsAllowed() after WebCore invoked cancelPermissionRequest(), which is incorrect. This could cause the Geolocation object to have erroneous permissions.

The dialog does not have to be dismissed on cancelPermissionRequest(), but the WebGeolocationPolicyListener should be disconnected from its Geolocation object.