Bug 89516 - [Qt][Mac] REGRESSION(r120742): It broke the build
Summary: [Qt][Mac] REGRESSION(r120742): It broke the build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All OS X 10.7
: P1 Blocker
Assignee: Mark Hahnenberg
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks: 89400
  Show dependency treegraph
 
Reported: 2012-06-19 14:35 PDT by Csaba Osztrogonác
Modified: 2012-06-19 17:20 PDT (History)
8 users (show)

See Also:


Attachments
Patch (16.04 KB, patch)
2012-06-19 15:16 PDT, Mark Hahnenberg
no flags Details | Formatted Diff | Diff
Patch (15.96 KB, patch)
2012-06-19 15:27 PDT, Mark Hahnenberg
no flags Details | Formatted Diff | Diff
Patch (16.52 KB, patch)
2012-06-19 15:35 PDT, Mark Hahnenberg
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2012-06-19 14:35:42 PDT
../../../../Source/JavaScriptCore/runtime/GCActivityCallback.cpp: In constructor ‘JSC::DefaultGCActivityCallback::DefaultGCActivityCallback(JSC::Heap*)’:
../../../../Source/JavaScriptCore/runtime/GCActivityCallback.cpp:37: error: no matching function for call to ‘JSC::GCActivityCallback::GCActivityCallback(JSC::JSGlobalData*)’
../../../../Source/JavaScriptCore/runtime/GCActivityCallback.h:54: note: candidates are: JSC::GCActivityCallback::GCActivityCallback(JSC::JSGlobalData*, __CFRunLoop*)
../../../../Source/JavaScriptCore/runtime/GCActivityCallback.h:44: note:                 JSC::GCActivityCallback::GCActivityCallback(const JSC::GCActivityCallback&)

Could you check it, please?
Comment 1 Mark Hahnenberg 2012-06-19 14:40:25 PDT
Why is USE(CF) true on Qt platforms?
Comment 2 Mark Hahnenberg 2012-06-19 14:44:10 PDT
(In reply to comment #1)
> Why is USE(CF) true on Qt platforms?

Ah, I see, on Darwin. Okay, working on a fix for this.
Comment 3 Mark Hahnenberg 2012-06-19 15:16:10 PDT
Created attachment 148439 [details]
Patch
Comment 4 Mark Hahnenberg 2012-06-19 15:27:32 PDT
Created attachment 148440 [details]
Patch
Comment 5 Mark Hahnenberg 2012-06-19 15:35:56 PDT
Created attachment 148442 [details]
Patch
Comment 6 Geoffrey Garen 2012-06-19 16:07:05 PDT
Comment on attachment 148442 [details]
Patch

r=me
Comment 7 WebKit Review Bot 2012-06-19 17:20:45 PDT
Comment on attachment 148442 [details]
Patch

Clearing flags on attachment: 148442

Committed r120778: <http://trac.webkit.org/changeset/120778>
Comment 8 WebKit Review Bot 2012-06-19 17:20:51 PDT
All reviewed patches have been landed.  Closing bug.