Bug 89510 - Layout test gamepad/gamepad-polling-access.html timing out on some bots
Summary: Layout test gamepad/gamepad-polling-access.html timing out on some bots
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Normal
Assignee: Scott Graham
URL:
Keywords:
: 112209 (view as bug list)
Depends on:
Blocks:
 
Reported: 2012-06-19 13:52 PDT by Kenneth Russell
Modified: 2013-03-12 17:28 PDT (History)
6 users (show)

See Also:


Attachments
Patch (3.44 KB, patch)
2013-03-12 16:57 PDT, James Robinson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Russell 2012-06-19 13:52:53 PDT
Example failure:

http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Win%20%28dbg%29%282%29/builds/10640

From the bot:

http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Win%20%28dbg%29%282%29

on:

http://build.chromium.org/p/chromium.webkit/console

Marking this as a known timeout. Scott indicated offline there's a patch in progress that should fix this problem.
Comment 1 Kenneth Russell 2012-06-19 15:01:42 PDT
Committed r120758: <http://trac.webkit.org/changeset/120758>
Comment 2 Kenneth Russell 2012-06-19 15:02:20 PDT
Accidentally closed the bug with the above TestExpectations update. Reopening.
Comment 3 James Robinson 2013-03-12 16:54:11 PDT
It's not timing out, it's crashing.  The call to std::copy(..., )'s second parameter is null because it's calling .begin() on an WTF::Vector<> with 0 size.
Comment 4 James Robinson 2013-03-12 16:57:11 PDT
*** Bug 112209 has been marked as a duplicate of this bug. ***
Comment 5 James Robinson 2013-03-12 16:57:26 PDT
Created attachment 192834 [details]
Patch
Comment 6 Kenneth Russell 2013-03-12 17:08:27 PDT
Comment on attachment 192834 [details]
Patch

Thanks for cleaning this up. r=me
Comment 7 WebKit Review Bot 2013-03-12 17:27:58 PDT
Comment on attachment 192834 [details]
Patch

Clearing flags on attachment: 192834

Committed r145631: <http://trac.webkit.org/changeset/145631>
Comment 8 WebKit Review Bot 2013-03-12 17:28:01 PDT
All reviewed patches have been landed.  Closing bug.