Bug 89509 - Web Inspector: extensionPanel.onSearch `action` strings should be enumerated
Summary: Web Inspector: extensionPanel.onSearch `action` strings should be enumerated
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL: https://code.google.com/chrome/extens...
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-19 13:36 PDT by Jan Keromnes
Modified: 2012-06-19 15:30 PDT (History)
11 users (show)

See Also:

Attachments
Patch (6.26 KB, patch)
2012-06-19 13:47 PDT, Jan Keromnes 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Keromnes 2012-06-19 13:36:04 PDT 
Cross-report from https://code.google.com/p/chromium/issues/detail?id=121094

From https://code.google.com/chrome/extensions/trunk/devtools.panels.html#event-ExtensionPanel-onSearch
> extensionPanel.onSearch.addListener(function(string action, string queryString) {...});

The possible values for `action` are:
- "cancelSearch"
- "performSearch"
- "nextSearchResult"
- "previousSearchResult"

They should be enumerated in the `chrome.devtools.panels.SearchAction` API.
Comment 1 Jan Keromnes 2012-06-19 13:47:41 PDT 
Created attachment 148410 [details]
Patch
Comment 2 Andrey Kosyakov 2012-06-19 13:53:11 PDT 
Comment on attachment 148410 [details]
Patch

LGTM
Comment 3 WebKit Review Bot 2012-06-19 15:30:26 PDT 
Comment on attachment 148410 [details]
Patch

Clearing flags on attachment: 148410

Committed r120760: <http://trac.webkit.org/changeset/120760>
Comment 4 WebKit Review Bot 2012-06-19 15:30:31 PDT 
All reviewed patches have been landed.  Closing bug.