RESOLVED FIXED89509
Web Inspector: extensionPanel.onSearch `action` strings should be enumerated 
https://bugs.webkit.org/show_bug.cgi?id=89509
Summary Web Inspector: extensionPanel.onSearch `action` strings should be enumerated
Jan Keromnes
Reported 2012-06-19 13:36:04 PDT
Cross-report from https://code.google.com/p/chromium/issues/detail?id=121094 From https://code.google.com/chrome/extensions/trunk/devtools.panels.html#event-ExtensionPanel-onSearch > extensionPanel.onSearch.addListener(function(string action, string queryString) {...}); The possible values for `action` are: - "cancelSearch" - "performSearch" - "nextSearchResult" - "previousSearchResult" They should be enumerated in the `chrome.devtools.panels.SearchAction` API.
Attachments
Patch (6.26 KB, patch)
2012-06-19 13:47 PDT, Jan Keromnes 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jan Keromnes
Comment 1 2012-06-19 13:47:41 PDT
Created attachment 148410 [details] Patch
Andrey Kosyakov
Comment 2 2012-06-19 13:53:11 PDT
Comment on attachment 148410 [details] Patch LGTM
WebKit Review Bot
Comment 3 2012-06-19 15:30:26 PDT
Comment on attachment 148410 [details] Patch Clearing flags on attachment: 148410 Committed r120760: <http://trac.webkit.org/changeset/120760>
WebKit Review Bot
Comment 4 2012-06-19 15:30:31 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.