Bug 89501 – [GTK] Remove Windows support from plugins/gtk/

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Kalev Lember]

The GTK+ port now uses plugins/gtk/ on Windows, which leaves PluginPackageGtk.cpp and PluginViewGtk.cpp solely for XP_UNIX platforms.

[Kalev Lember]

Created attachment 148396 [details]
Patch

[Martin Robinson]

Comment on attachment 148396 [details]
Patch

Perhaps it makes sense for non-XP_UNIX and non-Windows platforms to use the empty plugin support while/before we do this?

[Kalev Lember]

I think that would make sense. I'll put together a patch that switches other platforms to PluginPackageNone.cpp + PluginViewNone.cpp.

For Mac, I think it would make sense to eventually switch to PluginPackageMac.cpp + PluginViewMac.mm, but I'm not particularly interested in Mac right now.

Although from the look of it, I doubt anyone has built webkitgtk for non-X11 and non-win32 in a long time. For instance, the build files include WidgetBackingStoreCairo.cpp for Windows, and GtkWidgetBackingStoreX11.cpp for X11, and no backing store at all for other platforms. This surely can't build at all.

[Kalev Lember]

Created attachment 148882 [details]
[GTK] Use the empty plugin support on non-X11 and non-Windows platforms

[Martin Robinson]

Comment on attachment 148882 [details]
[GTK] Use the empty plugin support on non-X11 and non-Windows platforms

View in context: https://bugs.webkit.org/attachment.cgi?id=148882&action=review

> Source/WebCore/GNUmakefile.list.am:4834
> +# ----
> +# NPAPI plugin support
> +# ----
> +if TARGET_X11

There's no need to separate out plugin related files into their own lists. I think it's better just to organize everything by platform:

[Kalev Lember]

Created attachment 148893 [details]
[GTK] Use the empty plugin support on non-X11 and non-Windows platforms

Fair enough, updated the patch to go back to per-platform file lists.

[Martin Robinson]

Comment on attachment 148893 [details]
[GTK] Use the empty plugin support on non-X11 and non-Windows platforms

Thanks!

[WebKit Review Bot]

Comment on attachment 148893 [details]
[GTK] Use the empty plugin support on non-X11 and non-Windows platforms

Clearing flags on attachment: 148893

Committed r120993: <http://trac.webkit.org/changeset/120993>

[Martin Robinson]

Comment on attachment 148396 [details]
Patch

Great!

[WebKit Review Bot]

Comment on attachment 148396 [details]
Patch

Clearing flags on attachment: 148396

Committed r121445: <http://trac.webkit.org/changeset/121445>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.