Bug 89500 - [BlackBerry] Should check the return value of fromUTF8() before executing it.
Summary: [BlackBerry] Should check the return value of fromUTF8() before executing it.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-19 12:53 PDT by Yong Li
Modified: 2012-06-22 11:07 PDT (History)
2 users (show)

See Also:

Attachments
the patch (1.73 KB, patch)
2012-06-19 12:58 PDT, Yong Li 		no flags Details | Formatted Diff | Diff
again (1.91 KB, patch)
2012-06-19 13:02 PDT, Yong Li 		no flags Details | Formatted Diff | Diff
Another try (1.94 KB, patch)
2012-06-19 13:40 PDT, Yong Li 		rwlbuis: review+
Details | Formatted Diff | Diff
to commit (1.95 KB, patch)
2012-06-19 13:49 PDT, Yong Li 		webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Changelog again! (1.98 KB, patch)
2012-06-19 15:05 PDT, Yong Li 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yong Li 2012-06-19 12:53:13 PDT 
WebPagePrivate::executeJavaScript() should check the return value of fromUTF8() before executing it to avoid potential crash.
Comment 1 Yong Li 2012-06-19 12:58:17 PDT 
Created attachment 148397 [details]
the patch
Comment 2 Yong Li 2012-06-19 13:02:53 PDT 
Created attachment 148398 [details]
again
Comment 3 Yong Li 2012-06-19 13:40:16 PDT 
Created attachment 148408 [details]
Another try
Comment 4 Rob Buis 2012-06-19 13:46:10 PDT 
Comment on attachment 148408 [details]
Another try

View in context: https://bugs.webkit.org/attachment.cgi?id=148408&action=review

LGTM.

> Source/WebKit/blackberry/ChangeLog:9
> +        before executing the script to avoid potential crash on invalid script source.

Probably needs PR mention.
Comment 5 Yong Li 2012-06-19 13:49:08 PDT 
Created attachment 148411 [details]
to commit
Comment 6 WebKit Review Bot 2012-06-19 14:46:25 PDT 
Comment on attachment 148411 [details]
to commit

Rejecting attachment 148411 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
ipts/svn-apply', u'--force']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue/

Parsed 2 diffs from patch file(s).
patching file Source/WebKit/blackberry/Api/WebPage.cpp
Hunk #1 succeeded at 703 (offset 2 lines).
patching file Source/WebKit/blackberry/ChangeLog
patch: **** malformed patch at line 22:          [Blackberry] add a new Api named setAllowNotification


Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/12982521
Comment 7 Yong Li 2012-06-19 15:05:40 PDT 
Created attachment 148437 [details]
Changelog again!
Comment 8 WebKit Review Bot 2012-06-19 16:50:47 PDT 
Comment on attachment 148437 [details]
Changelog again!

Clearing flags on attachment: 148437

Committed r120774: <http://trac.webkit.org/changeset/120774>