Bug 89497 - webkitpy: Simplify fetch_bugs_matching_search()
Summary: webkitpy: Simplify fetch_bugs_matching_search()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Thiago Marcos P. Santos
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-19 12:21 PDT by Thiago Marcos P. Santos
Modified: 2012-06-19 18:31 PDT (History)
4 users (show)

See Also:


Attachments
Patch (2.90 KB, patch)
2012-06-19 12:26 PDT, Thiago Marcos P. Santos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Thiago Marcos P. Santos 2012-06-19 12:21:31 PDT
The author_email parameter is being used wrongly: urllib.quote(search_string) instead of urllib.quote(author_email). But I realized that it is only working because the parameter is not being used at all.
Comment 1 Thiago Marcos P. Santos 2012-06-19 12:26:26 PDT
Created attachment 148390 [details]
Patch
Comment 2 Adam Barth 2012-06-19 17:51:10 PDT
Comment on attachment 148390 [details]
Patch

Do you need to update an test-webkitpy tests?
Comment 3 WebKit Review Bot 2012-06-19 18:31:43 PDT
Comment on attachment 148390 [details]
Patch

Clearing flags on attachment: 148390

Committed r120785: <http://trac.webkit.org/changeset/120785>
Comment 4 WebKit Review Bot 2012-06-19 18:31:48 PDT
All reviewed patches have been landed.  Closing bug.