Bug 89495 - Web Inspector: Simplify InspectorIndexedDBAgent to use IDB metadata API
Summary: Web Inspector: Simplify InspectorIndexedDBAgent to use IDB metadata API
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Joshua Bell
URL:
Keywords:
Depends on: 88467
Blocks: 89701
  Show dependency tree / graph
 
Reported: 2012-06-19 11:58 PDT by Joshua Bell
Modified: 2012-06-24 08:07 PDT (History)
4 users (show)

See Also:

Attachments
Patch (4.69 KB, patch)
2012-06-22 14:47 PDT, Joshua Bell 		no flags Details | Formatted Diff | Diff
Patch (4.70 KB, patch)
2012-06-22 15:38 PDT, Joshua Bell 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joshua Bell 2012-06-19 11:58:02 PDT 
Right now the DatabaseLoaderCallback::execute() needs to grovel through IDB structures via transactions to gather the database schema (object stores, indexes).

Once http://webkit.org/b/88467 lands this can be replaced with a call to idbDatabase->metadata() which will provide everything via simple structs.
Comment 1 Joshua Bell 2012-06-21 15:57:35 PDT 
I can take this on, actually - I need to do it to unblock another patch I have in the works so I'll have this change locally already.
Comment 2 Joshua Bell 2012-06-22 14:47:12 PDT 
Created attachment 149109 [details]
Patch
Comment 3 Joshua Bell 2012-06-22 14:52:44 PDT 
Comment on attachment 149109 [details]
Patch

Dropping review bit - won't pass until the dependent bug lands.
Comment 4 Joshua Bell 2012-06-22 15:38:53 PDT 
Created attachment 149125 [details]
Patch
Comment 5 Joshua Bell 2012-06-22 16:04:12 PDT 
This can land now - vsevik@ - who'd be a good reviewer?
Comment 6 Vsevolod Vlasov 2012-06-24 06:17:50 PDT 
Comment on attachment 149125 [details]
Patch

I am :)
Comment 7 WebKit Review Bot 2012-06-24 08:07:11 PDT 
Comment on attachment 149125 [details]
Patch

Clearing flags on attachment: 149125

Committed r121117: <http://trac.webkit.org/changeset/121117>
Comment 8 WebKit Review Bot 2012-06-24 08:07:16 PDT 
All reviewed patches have been landed.  Closing bug.