Bug 89489 - Account for device scale factor when creating image for dragging.
Summary: Account for device scale factor when creating image for dragging.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Varun Jain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-19 11:36 PDT by Varun Jain
Modified: 2012-06-20 15:49 PDT (History)
4 users (show)

See Also:


Attachments
Patch (2.56 KB, patch)
2012-06-19 11:39 PDT, Varun Jain
no flags Details | Formatted Diff | Diff
Patch (4.19 KB, patch)
2012-06-19 16:29 PDT, Varun Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Varun Jain 2012-06-19 11:36:34 PDT
Account for device scale factor when creating image for dragging.
Comment 1 Varun Jain 2012-06-19 11:39:39 PDT
Created attachment 148376 [details]
Patch
Comment 2 Adam Barth 2012-06-19 15:53:26 PDT
Comment on attachment 148376 [details]
Patch

I've asked varunjain to add a ManualTest for this bug.
Comment 3 Varun Jain 2012-06-19 16:29:21 PDT
Created attachment 148455 [details]
Patch
Comment 4 Varun Jain 2012-06-19 16:29:56 PDT
(In reply to comment #2)
> (From update of attachment 148376 [details])
> I've asked varunjain to add a ManualTest for this bug.

Added ManualTest. PTAL.
Comment 5 Beth Dakin 2012-06-20 11:22:45 PDT
Can you please provide reproducible steps for this bug? I don't see any problems with drag images using Safari on a Retina MacBook Pro.
Comment 6 Beth Dakin 2012-06-20 11:26:48 PDT
Oh, I see. Looks like we fixed this in Mac-only code:

https://bugs.webkit.org/show_bug.cgi?id=67779
Comment 7 Beth Dakin 2012-06-20 11:27:31 PDT
Also: https://bugs.webkit.org/show_bug.cgi?id=67802
Comment 8 Adam Barth 2012-06-20 12:52:34 PDT
Beth, will this patch cause a problem for the apple-mac port?  If so, should we move the conversion from apple-mac specific code to cross-platform code?
Comment 9 Beth Dakin 2012-06-20 13:11:40 PDT
No, this should not cause any problems for Apple Mac. It looks like all of the functions that are patched here are inside this ifdef:

#if !PLATFORM(MAC) && !PLATFORM(WIN)

So we're all set. I think this is a fine way to go.
Comment 10 Adam Barth 2012-06-20 14:06:02 PDT
Beth, do you agree?
Comment 11 Adam Barth 2012-06-20 14:52:32 PDT
I fail at reading.  Sorry for the noise.
Comment 12 WebKit Review Bot 2012-06-20 15:49:27 PDT
Comment on attachment 148455 [details]
Patch

Clearing flags on attachment: 148455

Committed r120876: <http://trac.webkit.org/changeset/120876>
Comment 13 WebKit Review Bot 2012-06-20 15:49:33 PDT
All reviewed patches have been landed.  Closing bug.