RESOLVED FIXED 89483
[BlackBerry] Animations continue to request frames after they have finished 
https://bugs.webkit.org/show_bug.cgi?id=89483
Summary [BlackBerry] Animations continue to request frames after they have finished
Andrew Lo
Reported 2012-06-19 09:53:08 PDT
Internal PR165119 When DefaultTapHighlight hide() happens, it adds the fade animation to the overlay. However, it doesn't remove the animation until the next draw() call, which happens when the user touches another link. In between those two events, the animation is still part of m_runningAnimations in LayerCompositingThread, so it continuously requesting frames from AnimationFrameRateController in the WebPageCompositor. This results in much lower frame-rates when you go to http://www.craftymind.com/guimark3/ and click the link for the bitmap test. Going to the test without clicking a link & triggering the animation results in much faster frame-rates: http://www.craftymind.com/factory/guimark3/bitmap/GM3_JS_Bitmap.html You can also verify by enabling AFRC logging and checking that if the user touches one link, frames are requested continuously after, except when the user touches another link but hasn't released yet.
Attachments
Patch (7.92 KB, patch)
2012-06-19 10:11 PDT, Andrew Lo 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andrew Lo
Comment 1 2012-06-19 10:11:42 PDT
Created attachment 148354 [details] Patch
Rob Buis
Comment 2 2012-06-19 10:15:01 PDT
Comment on attachment 148354 [details] Patch LGTM.
WebKit Review Bot
Comment 3 2012-06-19 10:57:38 PDT
Comment on attachment 148354 [details] Patch Clearing flags on attachment: 148354 Committed r120734: <http://trac.webkit.org/changeset/120734>
WebKit Review Bot
Comment 4 2012-06-19 10:57:42 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.