Bug 89483 - [BlackBerry] Animations continue to request frames after they have finished
Summary: [BlackBerry] Animations continue to request frames after they have finished
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andrew Lo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-19 09:53 PDT by Andrew Lo
Modified: 2012-06-19 10:57 PDT (History)
2 users (show)

See Also:


Attachments
Patch (7.92 KB, patch)
2012-06-19 10:11 PDT, Andrew Lo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Lo 2012-06-19 09:53:08 PDT
Internal PR165119

When DefaultTapHighlight hide() happens, it adds the fade animation to the
overlay.

However, it doesn't remove the animation until the next draw() call, which
happens when the user touches another link. In between those two events, the
animation is still part of m_runningAnimations in LayerCompositingThread, so it
continuously requesting frames from AnimationFrameRateController in the
WebPageCompositor.

This results in much lower frame-rates when you go to
http://www.craftymind.com/guimark3/ and click the link for the bitmap test.

Going to the test without clicking a link & triggering the animation results in
much faster frame-rates:
http://www.craftymind.com/factory/guimark3/bitmap/GM3_JS_Bitmap.html

You can also verify by enabling AFRC logging and checking that if the user
touches one link, frames are requested continuously after, except when the user
touches another link but hasn't released yet.
Comment 1 Andrew Lo 2012-06-19 10:11:42 PDT
Created attachment 148354 [details]
Patch
Comment 2 Rob Buis 2012-06-19 10:15:01 PDT
Comment on attachment 148354 [details]
Patch

LGTM.
Comment 3 WebKit Review Bot 2012-06-19 10:57:38 PDT
Comment on attachment 148354 [details]
Patch

Clearing flags on attachment: 148354

Committed r120734: <http://trac.webkit.org/changeset/120734>
Comment 4 WebKit Review Bot 2012-06-19 10:57:42 PDT
All reviewed patches have been landed.  Closing bug.