Bug 89476 - Web Inspector: mark used/allocated JS heap on the native memory bar chart.
Summary: Web Inspector: mark used/allocated JS heap on the native memory bar chart.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Alexei Filippov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-19 08:40 PDT by Alexei Filippov
Modified: 2012-06-20 09:33 PDT (History)
11 users (show)

See Also:

Attachments
Patch (4.44 KB, patch)
2012-06-19 08:45 PDT, Alexei Filippov 		no flags Details | Formatted Diff | Diff
Patch (5.13 KB, patch)
2012-06-20 08:18 PDT, Alexei Filippov 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexei Filippov 2012-06-19 08:40:28 PDT 
EOM
Comment 1 Alexei Filippov 2012-06-19 08:45:15 PDT 
Created attachment 148345 [details]
Patch
Comment 2 Yury Semikhatsky 2012-06-19 23:53:39 PDT 
Comment on attachment 148345 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=148345&action=review

> Source/WebCore/inspector/front-end/NativeMemorySnapshotView.js:382
> +    this._unused = {};

Should we use one map name -> structure describing barDiv instead?

> Source/WebCore/inspector/front-end/NativeMemorySnapshotView.js:473
> +            var subChildrenSize = 0;

usedSize?
Comment 3 Alexei Filippov 2012-06-20 08:18:00 PDT 
Created attachment 148572 [details]
Patch
Comment 4 WebKit Review Bot 2012-06-20 09:33:42 PDT 
Comment on attachment 148572 [details]
Patch

Clearing flags on attachment: 148572

Committed r120829: <http://trac.webkit.org/changeset/120829>
Comment 5 WebKit Review Bot 2012-06-20 09:33:46 PDT 
All reviewed patches have been landed.  Closing bug.