Steps: 1. Launch inspector and navigate to Profiles panel 2. Click on start button to start a profiling session 3. Now click on "Clear all profiles" button at the bottom while the recording is ongoing. Expected Outcome: The profiles view should be reset Actual outcome: The buttons on the panel still shows Stop and the status bar record button still shows red.
Created attachment 148318 [details] Patch
Comment on attachment 148318 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=148318&action=review > Source/WebCore/inspector/front-end/ProfilesPanel.js:381 > + this.recordButton.title = ""; Could you call toggleRecordButton instead if we are currently profiling the page to leave correct button title?
(In reply to comment #2) > (From update of attachment 148318 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=148318&action=review > > > Source/WebCore/inspector/front-end/ProfilesPanel.js:381 > > + this.recordButton.title = ""; > > Could you call toggleRecordButton instead if we are currently profiling the page to leave correct button title? Thank you Yury for the review. I tried calling toggleRecordButton before this fix but this will result in calling the takeHeapSnapshot for HeapSnapshotView.js as toggleRecordButton invokes buttonClicked method. Hence have done some corrections to setting the correct tooltip after reset. Uploading it again for your review.
Created attachment 148322 [details] Patch
Comment on attachment 148322 [details] Patch Clearing flags on attachment: 148322 Committed r120809: <http://trac.webkit.org/changeset/120809>
All reviewed patches have been landed. Closing bug.