RESOLVED FIXED 89459
Speech JavaScript API: add SpeechRecognition.maxAlternatives attribute 
https://bugs.webkit.org/show_bug.cgi?id=89459
Summary Speech JavaScript API: add SpeechRecognition.maxAlternatives attribute
Hans Wennborg
Reported 2012-06-19 04:27:32 PDT
Speech JavaScript API: add SpeechRecognition.maxNBest attribute
Attachments
Patch (12.53 KB, patch)
2012-06-19 04:30 PDT, Hans Wennborg 		no flags
DetailsFormatted DiffDiff
Patch (13.51 KB, patch)
2012-06-20 03:37 PDT, Hans Wennborg 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Hans Wennborg
Comment 1 2012-06-19 04:30:40 PDT
Created attachment 148311 [details] Patch
WebKit Review Bot
Comment 2 2012-06-19 04:33:34 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Eric Seidel (no email)
Comment 3 2012-06-19 06:24:02 PDT
I assume there is a spec underway somewhere? A quick google search didn't find anything about this API.
Satish Sampath
Comment 4 2012-06-19 06:26:54 PDT
http://dvcs.w3.org/hg/speech-api/raw-file/tip/speechapi.html is the API.
Eric Seidel (no email)
Comment 5 2012-06-19 06:43:06 PDT
Thank you. :) I would encourage you to include that link (or a similar perma-link) in your ChangeLog for future patches/bugs. Just makes it easier for others to follow-along at home. No need to update this patch of course.
Eric Seidel (no email)
Comment 6 2012-06-19 06:44:17 PDT
Comment on attachment 148311 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=148311&action=review > LayoutTests/fast/speech/scripted/basics-expected.txt:14 > +PASS 'maxNBest' in speechReco is true Do you want to be checking true here or for a specific number?
Hans Wennborg
Comment 7 2012-06-19 06:47:51 PDT
(In reply to comment #5) > Thank you. :) I would encourage you to include that link (or a similar perma-link) in your ChangeLog for future patches/bugs. Just makes it easier for others to follow-along at home. No need to update this patch of course. Will do. (In reply to comment #6) > (From update of attachment 148311 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=148311&action=review > > > LayoutTests/fast/speech/scripted/basics-expected.txt:14 > > +PASS 'maxNBest' in speechReco is true > > Do you want to be checking true here or for a specific number? Ah, yes we should check the default value. Will fix.
Hans Wennborg
Comment 8 2012-06-20 03:21:51 PDT
This was renamed to maxAlternatives in the spec. New patch coming up.
Hans Wennborg
Comment 9 2012-06-20 03:37:39 PDT
Created attachment 148533 [details] Patch
Eric Seidel (no email)
Comment 10 2012-06-20 05:16:26 PDT
Comment on attachment 148533 [details] Patch OK.
WebKit Review Bot
Comment 11 2012-06-20 05:35:58 PDT
Comment on attachment 148533 [details] Patch Clearing flags on attachment: 148533 Committed r120817: <http://trac.webkit.org/changeset/120817>
WebKit Review Bot
Comment 12 2012-06-20 05:36:04 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.