Bug 89459 - Speech JavaScript API: add SpeechRecognition.maxAlternatives attribute
Summary: Speech JavaScript API: add SpeechRecognition.maxAlternatives attribute
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hans Wennborg
URL:
Keywords:
Depends on:
Blocks: 80261
  Show dependency tree / graph
 
Reported: 2012-06-19 04:27 PDT by Hans Wennborg
Modified: 2012-06-20 05:36 PDT (History)
10 users (show)

See Also:

Attachments
Patch (12.53 KB, patch)
2012-06-19 04:30 PDT, Hans Wennborg 		no flags Details | Formatted Diff | Diff
Patch (13.51 KB, patch)
2012-06-20 03:37 PDT, Hans Wennborg 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hans Wennborg 2012-06-19 04:27:32 PDT 
Speech JavaScript API: add SpeechRecognition.maxNBest attribute
Comment 1 Hans Wennborg 2012-06-19 04:30:40 PDT 
Created attachment 148311 [details]
Patch
Comment 2 WebKit Review Bot 2012-06-19 04:33:34 PDT 
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 Eric Seidel (no email) 2012-06-19 06:24:02 PDT 
I assume there is a spec underway somewhere?  A quick google search didn't find anything about this API.
Comment 4 Satish Sampath 2012-06-19 06:26:54 PDT 
http://dvcs.w3.org/hg/speech-api/raw-file/tip/speechapi.html is the API.
Comment 5 Eric Seidel (no email) 2012-06-19 06:43:06 PDT 
Thank you. :)  I would encourage you to include that link (or a similar perma-link) in your ChangeLog for future patches/bugs. Just makes it easier for others to follow-along at home.  No need to update this patch of course.
Comment 6 Eric Seidel (no email) 2012-06-19 06:44:17 PDT 
Comment on attachment 148311 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=148311&action=review

> LayoutTests/fast/speech/scripted/basics-expected.txt:14
> +PASS 'maxNBest' in speechReco is true

Do you want to be checking true here or for a specific number?
Comment 7 Hans Wennborg 2012-06-19 06:47:51 PDT 
(In reply to comment #5)
> Thank you. :)  I would encourage you to include that link (or a similar perma-link) in your ChangeLog for future patches/bugs. Just makes it easier for others to follow-along at home.  No need to update this patch of course.

Will do.

(In reply to comment #6)
> (From update of attachment 148311 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=148311&action=review
> 
> > LayoutTests/fast/speech/scripted/basics-expected.txt:14
> > +PASS 'maxNBest' in speechReco is true
> 
> Do you want to be checking true here or for a specific number?

Ah, yes we should check the default value. Will fix.
Comment 8 Hans Wennborg 2012-06-20 03:21:51 PDT 
This was renamed to maxAlternatives in the spec.

New patch coming up.
Comment 9 Hans Wennborg 2012-06-20 03:37:39 PDT 
Created attachment 148533 [details]
Patch
Comment 10 Eric Seidel (no email) 2012-06-20 05:16:26 PDT 
Comment on attachment 148533 [details]
Patch

OK.
Comment 11 WebKit Review Bot 2012-06-20 05:35:58 PDT 
Comment on attachment 148533 [details]
Patch

Clearing flags on attachment: 148533

Committed r120817: <http://trac.webkit.org/changeset/120817>
Comment 12 WebKit Review Bot 2012-06-20 05:36:04 PDT 
All reviewed patches have been landed.  Closing bug.