89457 – [chromium] Remove duplicate mock CCLayerTreeHostClient

Bug 89457 - [chromium] Remove duplicate mock CCLayerTreeHostClient

Summary: [chromium] Remove duplicate mock CCLayerTreeHostClient

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	New Bugs (show other bugs)
Version:	528+ (Nightly build)
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Sami Kyöstilä

URL:
Keywords:

Depends on:
Blocks:

Reported:	2012-06-19 04:06 PDT by Sami Kyöstilä
Modified:	2012-07-19 07:44 PDT (History)
CC List:	3 users (show)

See Also:

Attachments
Patch (2.94 KB, patch) 2012-06-19 04:07 PDT, Sami Kyöstilä	no flags	Details \| Formatted Diff \| Diff
Patch (2.92 KB, patch) 2012-07-19 02:26 PDT, Sami Kyöstilä	no flags	Details \| Formatted Diff \| Diff
Patch (2.92 KB, patch) 2012-07-19 05:57 PDT, Sami Kyöstilä	no flags	Details \| Formatted Diff \| Diff
Patch (2.92 KB, patch) 2012-07-19 06:06 PDT, Sami Kyöstilä	no flags	Details \| Formatted Diff \| Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Sami Kyöstilä 2012-06-19 04:06:42 PDT

[chromium] Remove duplicate mock CCLayerTreeHostClient

Comment 1 Sami Kyöstilä 2012-06-19 04:07:44 PDT

Created attachment 148309 [details]
Patch

Comment 2 Adrienne Walker 2012-07-18 14:51:48 PDT

Comment on attachment 148309 [details]
Patch

Belated R=me.  Nobody got CC'd on this bug, which is why it languished.

Comment 3 WebKit Review Bot 2012-07-18 15:07:51 PDT

Comment on attachment 148309 [details]
Patch

Rejecting attachment 148309 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
 from patch file(s).
patching file Source/WebKit/chromium/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebKit/chromium/tests/GraphicsLayerChromiumTest.cpp
Hunk #1 FAILED at 28.
Hunk #2 FAILED at 59.
2 out of 2 hunks FAILED -- saving rejects to file Source/WebKit/chromium/tests/GraphicsLayerChromiumTest.cpp.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Adrienne W..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/13273645

Comment 4 Sami Kyöstilä 2012-07-19 02:25:40 PDT

Thanks Enne! My bad for failing to CC anyone. Rebased patch coming up.

Comment 5 Sami Kyöstilä 2012-07-19 02:26:44 PDT

Created attachment 153212 [details]
Patch

- Rebased.

Comment 6 Sami Kyöstilä 2012-07-19 05:57:54 PDT

Created attachment 153240 [details]
Patch

- Marking as reviewed.

Comment 7 Sami Kyöstilä 2012-07-19 06:06:00 PDT

Created attachment 153242 [details]
Patch

Comment 8 Peter Beverloo 2012-07-19 06:06:28 PDT

Comment on attachment 153242 [details]
Patch

Setting cq+ on request.

Comment 9 WebKit Review Bot 2012-07-19 07:44:30 PDT

Comment on attachment 153242 [details]
Patch

Clearing flags on attachment: 153242

Committed r123101: <http://trac.webkit.org/changeset/123101>

Comment 10 WebKit Review Bot 2012-07-19 07:44:35 PDT

All reviewed patches have been landed.  Closing bug.