Bug 89449 – [Qt] Buildfix for newer Qt5

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Csaba Osztrogonác]

After ee7fa67eb0060b9c794bae4c7b06110c3b9626e0 in qtbase, QWeakPointer 
is deprecated, we should use QPointer instead of QWeakPointer.

Patch is coming soon.

[Csaba Osztrogonác]

Created attachment 148296 [details]
Patch

[Simon Hausmann]

Comment on attachment 148296 [details]
Patch

r=me. this is safe to land even before the update.

[Early Warning System Bot]

Comment on attachment 148296 [details]
Patch

Attachment 148296 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/12973661

[Csaba Osztrogonác]

Comment on attachment 148296 [details]
Patch

We need ifdef guards for Qt 4.8 build. :-/

[Simon Hausmann]

(In reply to comment #4)
> (From update of attachment 148296 [details])
> We need ifdef guards for Qt 4.8 build. :-/

I think it would be easier to change the calls to clear() with a null pointer assignment, i.e.

    foopointer.clear();

with

    foopointer = 0;

and thus avoid the #ifdefs.

[Csaba Osztrogonác]

(In reply to comment #5)
> (In reply to comment #4)
> > (From update of attachment 148296 [details] [details])
> > We need ifdef guards for Qt 4.8 build. :-/
> 
> I think it would be easier to change the calls to clear() with a null pointer assignment, i.e.
> 
>     foopointer.clear();
> 
> with
> 
>     foopointer = 0;
> 
> and thus avoid the #ifdefs.

let me check and fix it

[Andras Becsi]

*** Bug 89029 has been marked as a duplicate of this bug. ***

[Andras Becsi]

(In reply to comment #6)
> (In reply to comment #5)
> > (In reply to comment #4)
> > > (From update of attachment 148296 [details] [details] [details])
> > > We need ifdef guards for Qt 4.8 build. :-/
> > 
> > I think it would be easier to change the calls to clear() with a null pointer assignment, i.e.
> > 
> >     foopointer.clear();
> > 
> > with
> > 
> >     foopointer = 0;
> > 
> > and thus avoid the #ifdefs.
> 
> let me check and fix it

I think there is a fix in qtbase for the clear() function in a newer hash, it just did not make it to the supermodule yet.

[Csaba Osztrogonác]

(In reply to comment #8)
> I think there is a fix in qtbase for the clear() function in a newer hash, it just did not make it to the supermodule yet.

The latest Qt5 hash contains QPointer.clear(), but Qt 4.8's QPointer() doesn't.

[Csaba Osztrogonác]

Created attachment 148308 [details]
Patch

Use zero assignment instead of QPointer.clear(), because Qt4's QPointer class doesn't have clear method.

[Csaba Osztrogonác]

Comment on attachment 148308 [details]
Patch

Landed in http://trac.webkit.org/changeset/120704