RESOLVED FIXED 89435
[GTK] Don't run the tests with jhbuild wrapper if it's already running under jhbuild 
https://bugs.webkit.org/show_bug.cgi?id=89435
Summary [GTK] Don't run the tests with jhbuild wrapper if it's already running under ...
Carlos Garcia Campos
Reported 2012-06-18 23:42:31 PDT
This would allow to run the tests using an external jhbuild.
Attachments
Patch (1.24 KB, patch)
2012-06-18 23:44 PDT, Carlos Garcia Campos 		mrobinson: review-
DetailsFormatted DiffDiff
Updated patch (1.33 KB, patch)
2012-07-02 03:32 PDT, Carlos Garcia Campos 		mrobinson: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from gce-cr-linux-02 (361.74 KB, application/zip)
2012-07-02 08:34 PDT, WebKit Review Bot 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2012-06-18 23:44:05 PDT
Created attachment 148264 [details] Patch
Martin Robinson
Comment 2 2012-06-19 00:12:47 PDT
Comment on attachment 148264 [details] Patch This breaks usecases where users want to use the WebKit jhbuild, but are already in another jhbuild shell. Tests aren't expected to pass outside the WebKit jhbuild anyhow. I think it would be better to simply make the scripts not use JHbuild if update-webkitgtk-libs has never been run.
Carlos Garcia Campos
Comment 3 2012-07-02 03:32:07 PDT
Created attachment 150390 [details] Updated patch
WebKit Review Bot
Comment 4 2012-07-02 08:34:31 PDT
Comment on attachment 150390 [details] Updated patch Attachment 150390 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13131180 New failing tests: fast/loader/loadInProgress.html
WebKit Review Bot
Comment 5 2012-07-02 08:34:34 PDT
Created attachment 150428 [details] Archive of layout-test-results from gce-cr-linux-02 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: gce-cr-linux-02 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Carlos Garcia Campos
Comment 6 2012-07-02 08:54:53 PDT
Committed r121681: <http://trac.webkit.org/changeset/121681>
Note You need to log in before you can comment on or make changes to this bug.