Bug 89435 - [GTK] Don't run the tests with jhbuild wrapper if it's already running under jhbuild
Summary: [GTK] Don't run the tests with jhbuild wrapper if it's already running under ...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
Keywords: Gtk
Depends on:
Reported: 2012-06-18 23:42 PDT by Carlos Garcia Campos
Modified: 2012-07-02 08:54 PDT (History)
5 users (show)

See Also:

Patch (1.24 KB, patch)
2012-06-18 23:44 PDT, Carlos Garcia Campos
mrobinson: review-
Details | Formatted Diff | Diff
Updated patch (1.33 KB, patch)
2012-07-02 03:32 PDT, Carlos Garcia Campos
mrobinson: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from gce-cr-linux-02 (361.74 KB, application/zip)
2012-07-02 08:34 PDT, WebKit Review Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2012-06-18 23:42:31 PDT
This would allow to run the tests using an external jhbuild.
Comment 1 Carlos Garcia Campos 2012-06-18 23:44:05 PDT
Created attachment 148264 [details]
Comment 2 Martin Robinson 2012-06-19 00:12:47 PDT
Comment on attachment 148264 [details]

This breaks usecases where users want to use the WebKit jhbuild, but are already in another jhbuild shell. Tests aren't expected to pass outside the WebKit jhbuild anyhow.

I think it would be better to simply make the scripts not use JHbuild if update-webkitgtk-libs has never been run.
Comment 3 Carlos Garcia Campos 2012-07-02 03:32:07 PDT
Created attachment 150390 [details]
Updated patch
Comment 4 WebKit Review Bot 2012-07-02 08:34:31 PDT
Comment on attachment 150390 [details]
Updated patch

Attachment 150390 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13131180

New failing tests:
Comment 5 WebKit Review Bot 2012-07-02 08:34:34 PDT
Created attachment 150428 [details]
Archive of layout-test-results from gce-cr-linux-02

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-02  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Comment 6 Carlos Garcia Campos 2012-07-02 08:54:53 PDT
Committed r121681: <http://trac.webkit.org/changeset/121681>