Bug 89433 - REGRESSION(120552): Many tests timing out on Windows
Summary: REGRESSION(120552): Many tests timing out on Windows
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Windows 7
: P2 Normal
Assignee: Jon Honeycutt
URL:
Keywords: MakingBotsRed, PlatformOnly
Depends on:
Blocks:
 
Reported: 2012-06-18 23:38 PDT by Jon Honeycutt
Modified: 2012-06-19 02:21 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.75 KB, patch)
2012-06-19 01:10 PDT, Jon Honeycutt 		aestes: review+
aestes: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jon Honeycutt 2012-06-18 23:38:16 PDT 
I think that any test using layoutTestController.waitUntilDone() is timing out on Windows after <http://trac.webkit.org/changeset/120552>.
Comment 1 Jon Honeycutt 2012-06-19 01:10:59 PDT 
Created attachment 148281 [details]
Patch
Comment 2 Andy Estes 2012-06-19 01:52:03 PDT 
Comment on attachment 148281 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=148281&action=review

> Source/WTF/ChangeLog:3
> +        REGRESSION(120552): Many tests timing out on Windows

"REGRESSION (r120552): ...", for consistency.

> Source/WTF/wtf/CurrentTime.cpp:74
> +static const double hundredsOfNanosecondsPerMillisecond = 10000.0;

No need for the .0
Comment 3 Jon Honeycutt 2012-06-19 02:21:34 PDT 
Thanks for the review! Landed in <http://trac.webkit.org/changeset/120697>.