Bug 89430 - [CSS Regions] CSS regions should be re-enabled on Windows
Summary: [CSS Regions] CSS regions should be re-enabled on Windows
Status: RESOLVED DUPLICATE of bug 90435
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
: 82047 (view as bug list)
Depends on:
Blocks: 57312
  Show dependency treegraph
 
Reported: 2012-06-18 23:32 PDT by Jon Honeycutt
Modified: 2012-11-22 07:09 PST (History)
5 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jon Honeycutt 2012-06-18 23:32:46 PDT
Enabling CSS regions (<http://trac.webkit.org/changeset/120280>) caused all Windows tests to crash: 

<http://build.webkit.org/builders/Apple%20Win%207%20Release%20%28Tests%29/builds/24746> (120279)
<http://build.webkit.org/builders/Apple%20Win%207%20Release%20%28Tests%29/builds/24747> (120280)

The crash occurred when trying to write to the static bool value WebCore::RuntimeEnabledFeatures::isCSSExclusionsEnabled from WebCore::InternalSettings::restoreTo(). I believe that we are exporting this bool data member incorrectly.

r120280 was rolled out in <http://trac.webkit.org/changeset/120523>. It should be rolled back in when the crashing bug is fixed.
Comment 1 Mihai Balan 2012-11-22 00:08:06 PST
The crashes  were fixed in #90435.

*** This bug has been marked as a duplicate of bug 90435 ***
Comment 2 Mihai Balan 2012-11-22 07:09:11 PST
*** Bug 82047 has been marked as a duplicate of this bug. ***