Bug 89423 – [EFL] Support screenDepth() functionality.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Gyuyoung Kim]

Support screenDepth() based on ecore_x_window_depth_get(). This functionality may be used by both WebKit1 and WebKit2. So, concrete function is placed into EflScreenUtilities.cpp. This patch can't support existing test cases. Because, EFL DumpRenderTree works without X11 window by default.

http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/efl/DumpRenderTree.cpp#L69

[Gyuyoung Kim]

Created attachment 148250 [details]
Patch

[Gyuyoung Kim]

Created attachment 148253 [details]
Patch

[Gyuyoung Kim]

Created attachment 148254 [details]
Patch

[Gyuyoung Kim]

CC'ing Antonio.

[Kenneth Rohde Christiansen]

Comment on attachment 148254 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=148254&action=review

> Source/WebCore/platform/efl/EflScreenUtilities.cpp:139
> +    if (!window)
> +        return 0;

Is that a good value? depth of 0 ? Why not just return 8 like below?

[Gyuyoung Kim]

Created attachment 149296 [details]
Patch

[Gyuyoung Kim]

Created attachment 149307 [details]
Patch

[Gyuyoung Kim]

(In reply to comment #5)
> (From update of attachment 148254 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=148254&action=review
> 
> > Source/WebCore/platform/efl/EflScreenUtilities.cpp:139
> > +    if (!window)
> > +        return 0;
> 
> Is that a good value? depth of 0 ? Why not just return 8 like below?

Yes, I fix it. Thanks.

[WebKit Review Bot]

Comment on attachment 149307 [details]
Patch

Clearing flags on attachment: 149307

Committed r121163: <http://trac.webkit.org/changeset/121163>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.