WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
89420
Web Inspector: Unify FileSystem callbacks.
https://bugs.webkit.org/show_bug.cgi?id=89420
Summary
Web Inspector: Unify FileSystem callbacks.
Taiju Tsuiki
Reported
2012-06-18 22:07:03 PDT
InspectorFileSystemAgent.cpp has some callback dispatcher classes which are almost same each other, and similar class is going to increase in this way. I'd like to unify them to single template class to reduce duplication.
Attachments
Patch
(11.05 KB, patch)
2012-06-18 22:10 PDT
,
Taiju Tsuiki
no flags
Details
Formatted Diff
Diff
Patch
(11.13 KB, patch)
2012-06-21 04:13 PDT
,
Taiju Tsuiki
no flags
Details
Formatted Diff
Diff
Patch
(11.09 KB, patch)
2012-06-21 06:52 PDT
,
Taiju Tsuiki
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Taiju Tsuiki
Comment 1
2012-06-18 22:10:00 PDT
Created
attachment 148246
[details]
Patch
Vsevolod Vlasov
Comment 2
2012-06-21 01:30:57 PDT
Comment on
attachment 148246
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=148246&action=review
> Source/WebCore/inspector/InspectorFileSystemAgent.cpp:181 > + RefPtr<EntryCallback> successCallback = createCallbackDispatcher(TypeParam<EntryCallback>(), this, &GetFileSystemRootTask::gotEntry);
I think you can remove TypaParam argument and do createCallbackDispatcher<EntryCallback>(this, &GetFileSystemRootTask::gotEntry); instead.
Taiju Tsuiki
Comment 3
2012-06-21 04:13:08 PDT
Created
attachment 148762
[details]
Patch
Taiju Tsuiki
Comment 4
2012-06-21 04:20:52 PDT
Comment on
attachment 148246
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=148246&action=review
>> Source/WebCore/inspector/InspectorFileSystemAgent.cpp:181 >> + RefPtr<EntryCallback> successCallback = createCallbackDispatcher(TypeParam<EntryCallback>(), this, &GetFileSystemRootTask::gotEntry); > > I think you can remove TypaParam argument and do > createCallbackDispatcher<EntryCallback>(this, &GetFileSystemRootTask::gotEntry); > instead.
We can't pass template parameter partially. Another option is like that: CallbackDispatcher<EntryCallback>::create(...). Is it acceptable?
Taiju Tsuiki
Comment 5
2012-06-21 06:52:42 PDT
Created
attachment 148789
[details]
Patch
WebKit Review Bot
Comment 6
2012-06-21 08:28:26 PDT
Comment on
attachment 148789
[details]
Patch Clearing flags on attachment: 148789 Committed
r120926
: <
http://trac.webkit.org/changeset/120926
>
WebKit Review Bot
Comment 7
2012-06-21 08:28:32 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug