Bug 89420 - Web Inspector: Unify FileSystem callbacks.
Summary: Web Inspector: Unify FileSystem callbacks.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Taiju Tsuiki
URL:
Keywords:
Depends on: 88602
Blocks: 68203 87856 89642
  Show dependency tree / graph
 
Reported: 2012-06-18 22:07 PDT by Taiju Tsuiki
Modified: 2012-06-21 08:28 PDT (History)
11 users (show)

See Also:

Attachments
Patch (11.05 KB, patch)
2012-06-18 22:10 PDT, Taiju Tsuiki 		no flags Details | Formatted Diff | Diff
Patch (11.13 KB, patch)
2012-06-21 04:13 PDT, Taiju Tsuiki 		no flags Details | Formatted Diff | Diff
Patch (11.09 KB, patch)
2012-06-21 06:52 PDT, Taiju Tsuiki 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Taiju Tsuiki 2012-06-18 22:07:03 PDT 
InspectorFileSystemAgent.cpp has some callback dispatcher classes which are almost same each other, and similar class is going to increase in this way.
I'd like to unify them to single template class to reduce duplication.
Comment 1 Taiju Tsuiki 2012-06-18 22:10:00 PDT 
Created attachment 148246 [details]
Patch
Comment 2 Vsevolod Vlasov 2012-06-21 01:30:57 PDT 
Comment on attachment 148246 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=148246&action=review

> Source/WebCore/inspector/InspectorFileSystemAgent.cpp:181
> +    RefPtr<EntryCallback> successCallback = createCallbackDispatcher(TypeParam<EntryCallback>(), this, &GetFileSystemRootTask::gotEntry);

I think you can remove TypaParam argument and do 
  createCallbackDispatcher<EntryCallback>(this, &GetFileSystemRootTask::gotEntry); 
instead.
Comment 3 Taiju Tsuiki 2012-06-21 04:13:08 PDT 
Created attachment 148762 [details]
Patch
Comment 4 Taiju Tsuiki 2012-06-21 04:20:52 PDT 
Comment on attachment 148246 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=148246&action=review

>> Source/WebCore/inspector/InspectorFileSystemAgent.cpp:181
>> +    RefPtr<EntryCallback> successCallback = createCallbackDispatcher(TypeParam<EntryCallback>(), this, &GetFileSystemRootTask::gotEntry);
> 
> I think you can remove TypaParam argument and do 
>   createCallbackDispatcher<EntryCallback>(this, &GetFileSystemRootTask::gotEntry); 
> instead.

We can't pass template parameter partially. Another option is like that: CallbackDispatcher<EntryCallback>::create(...).
Is it acceptable?
Comment 5 Taiju Tsuiki 2012-06-21 06:52:42 PDT 
Created attachment 148789 [details]
Patch
Comment 6 WebKit Review Bot 2012-06-21 08:28:26 PDT 
Comment on attachment 148789 [details]
Patch

Clearing flags on attachment: 148789

Committed r120926: <http://trac.webkit.org/changeset/120926>
Comment 7 WebKit Review Bot 2012-06-21 08:28:32 PDT 
All reviewed patches have been landed.  Closing bug.