Bug 89417 - Introduce an LRU cache around CSSParser::parseValue to prevent variables from needing to re-parse unnecessarily.
Summary: Introduce an LRU cache around CSSParser::parseValue to prevent variables from...
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Luke Macpherson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-18 20:56 PDT by Luke Macpherson
Modified: 2012-10-16 17:23 PDT (History)
9 users (show)

See Also:

Attachments
Patch (19.12 KB, patch)
2012-06-18 21:08 PDT, Luke Macpherson 		ap: review-
webkit-ews: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Luke Macpherson 2012-06-18 20:56:41 PDT 
Introduce an LRU cache around CSSParser::parseValue to prevent variables from needing to re-parse unnecessarily.
Comment 1 Luke Macpherson 2012-06-18 21:08:47 PDT 
Created attachment 148239 [details]
Patch
Comment 2 Early Warning System Bot 2012-06-18 21:24:01 PDT 
Comment on attachment 148239 [details]
Patch

Attachment 148239 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/12974598
Comment 3 Build Bot 2012-06-18 21:25:10 PDT 
Comment on attachment 148239 [details]
Patch

Attachment 148239 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/12979349
Comment 4 Early Warning System Bot 2012-06-18 21:25:23 PDT 
Comment on attachment 148239 [details]
Patch

Attachment 148239 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/12974599
Comment 5 WebKit Review Bot 2012-06-18 22:44:51 PDT 
Comment on attachment 148239 [details]
Patch

Attachment 148239 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12968962
Comment 6 Alexey Proskuryakov 2012-06-19 10:58:51 PDT 
Comment on attachment 148239 [details]
Patch

This is a lot of new code without any rationale. If this improves performance, please tell what your benchmark is.
Comment 7 Luke Macpherson 2012-06-19 17:33:08 PDT 
As Antti said on bug 85580:
"Parsing CSS values on style resolve time is going to be horribly slow. A good approach might be to cache the parsed values to the variable declaration value itself (with id/type key)."
This patch implements that request.
Comment 8 Antti Koivisto 2012-06-19 19:22:13 PDT 
(In reply to comment #7)
> As Antti said on bug 85580:
> "Parsing CSS values on style resolve time is going to be horribly slow. A good approach might be to cache the parsed values to the variable declaration value itself (with id/type key)."
> This patch implements that request.

This patch does not resemble my comment at all.