Bug 89409 – Unmodified form control value is overwritten by another form control value with the same name after navigating and going back

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Kent Tamura]

http://code.google.com/p/chromium/issues/detail?id=76739

If a page has multiple form controls of which names are identical like the following,
  <input type=text name=name1 id=input1>
  <input type=text name=name1 id=input2>
and a user update the value of the second control, then go to another page and go back to the page again,

Expected:
 The second input has the value which the user entered.

Actual:
 The first input has the value which the user entered, and the second input has the initial value.

[Kent Tamura]

Created attachment 148503 [details]
WIP

[WebKit Review Bot]

Attachment 148503 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1
Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Review Bot]

Comment on attachment 148503 [details]
WIP

Attachment 148503 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13004116

New failing tests:
fast/forms/state-restore-to-non-edited-controls.html

[WebKit Review Bot]

Created attachment 148509 [details]
Archive of layout-test-results from ec2-cr-linux-04

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-04  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

[Kent Tamura]

Created attachment 148534 [details]
Patch

[Hajime Morrita]

Comment on attachment 148534 [details]
Patch

The state (de)serialization flow looks becoming a bit cryptic. 
My feeling is that it is because the state is stored as a string vector instead of string.
If we control the format, the code will become much cleaner.

[WebKit Review Bot]

Comment on attachment 148534 [details]
Patch

Clearing flags on attachment: 148534

Committed r120895: <http://trac.webkit.org/changeset/120895>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.