In WebCore/platform/mac/CursorMac.mm, the panning and resize cursors all match, except for west. With the west panning cursor, it's mapped to EastWestResize.
Created attachment 148212 [details] Patch
Do you have a test case showing this in action?
There are two ways to get the west panning cursor. One is to explicitly call Cursor::westPanningCursor, which is only called from EventHandler::updatePanScrollState. Since PAN_SCROLLING isn't enabled on the Mac, this case is never seen. The other way to get that cursor is Cursor::fromType(Cursor::WestPanning), which is only called from WebKit2/Shared/WebCoreArgumentCoders.cpp, ArgumentCoder<Cursor>::decode. I'm not sure how to trace that back.
I don't see what the issue is here. Panning cursors aren't usually compiled into the Mac build, so if we have them in CursorMac at all, we might as well get them right.
Comment on attachment 148212 [details] Patch Rejecting attachment 148212 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: : /mnt/git/webkit-commit-queue Parsed 2 diffs from patch file(s). patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/platform/mac/CursorMac.mm Hunk #1 FAILED at 188. Hunk #2 FAILED at 204. 2 out of 2 hunks FAILED -- saving rejects to file Source/WebCore/platform/mac/CursorMac.mm.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', '--force', '--reviewer', 'Darin Adler']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/15901149
Darin, Thank you for the r+; I will upload a new version of this patch tomorrow.
Created attachment 182984 [details] updated version
Comment on attachment 182984 [details] updated version This was already reviewed, so you could have updated ChangeLog with Darin's name, and only requested cq? flag.
Comment on attachment 182984 [details] updated version Clearing flags on attachment: 182984 Committed r139889: <http://trac.webkit.org/changeset/139889>
All reviewed patches have been landed. Closing bug.
(In reply to comment #8) > (From update of attachment 182984 [details]) > This was already reviewed, so you could have updated ChangeLog with Darin's name, and only requested cq? flag. OK. I'm not that familiar with the WebKit review process, so the next time I will keep that in mind.