Bug 89403 – The CSS_WRAP_SHAPE CSSWrapShape::Type is no longer needed

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Hans Muller]

The CSS_WRAP_SHAPE_PATH definition should be removed from CSSWrapShapes.h.   It's no longer required by the CSS Exclusions spec - http://dev.w3.org/csswg/css3-exclusions/#shapes.

[Hans Muller]

I will upload a patch shortly.

[Hans Muller]

Created attachment 148227 [details]
Patch

[WebKit Review Bot]

Attachment 148227 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/ChangeLog:9:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Hans Muller]

Created attachment 148247 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 148247 [details]
Patch

LGTM.

[WebKit Review Bot]

Comment on attachment 148247 [details]
Patch

Rejecting attachment 148247 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

ERROR: /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/12991034

[Eric Seidel (no email)]

Comment on attachment 148247 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=148247&action=review

You'll need to upload a new patch or wait until bug 67935 is resolved. :)

> Source/WebCore/ChangeLog:5
> +

Looks like you remove the Reviewed by Nobody (OOPS!). line which prepare-ChangeLog inserts (and the commit-queue/webkit-patch knows to look for and fill-in when landing patches for you).  Without that line, the commit-queue won't work for you. :(  Bug 67935 exists to solve this common error. :(  Sorry!

[Eric Seidel (no email)]

Comment on attachment 148247 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=148247&action=review

> Source/WebCore/ChangeLog:1
> [phone]  Hans Muller  <[e-mail]>

The ChangeLog should be able to handle ü if your last name actually contains one. :)  You might want to chat with Tor Arne Vestø to check the current status of our tools unicode support though. :)

[Hans Muller]

Created attachment 148357 [details]
Patch

[Hans Muller]

Restored the 'Reviewed by NOBODY (OOPS!)' line I'd inadvertently deleted from the ChangeLog.   Perfection still eludes me :-).

[Eric Seidel (no email)]

Comment on attachment 148357 [details]
Patch

LGTM.

[WebKit Review Bot]

Comment on attachment 148357 [details]
Patch

Clearing flags on attachment: 148357

Committed r120764: <http://trac.webkit.org/changeset/120764>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.