Bug 89393 - RenderLayer subtrees without any self-painting layer shouldn't be walked during hit testing
Summary: RenderLayer subtrees without any self-painting layer shouldn't be walked duri...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Julien Chaffraix
URL:
Keywords:
Depends on:
Blocks: 89389
  Show dependency treegraph
 
Reported: 2012-06-18 15:30 PDT by Julien Chaffraix
Modified: 2012-10-17 16:33 PDT (History)
7 users (show)

See Also:


Attachments
Proposed performance change 1. (4.02 KB, patch)
2012-06-18 15:51 PDT, Julien Chaffraix
no flags Details | Formatted Diff | Diff
Patch for landing (4.06 KB, patch)
2012-10-17 15:43 PDT, Julien Chaffraix
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Julien Chaffraix 2012-06-18 15:30:38 PDT
Bug 88888 added an optimization to avoid walking such subtrees during painting but it didn't patch the hit testing path.

On http://dglazkov.github.com/performance-tests/biggrid.html, hit testing is suffering from the same over-head as painting: merely traversing a lot of non-self-painting-layers is proving costly. This means hit testing would benefit from the same optimization.
Comment 1 Julien Chaffraix 2012-06-18 15:51:02 PDT
Created attachment 148191 [details]
Proposed performance change 1.
Comment 2 Eric Seidel (no email) 2012-10-17 13:24:53 PDT
Comment on attachment 148191 [details]
Proposed performance change 1.

Looks reasonable.
Comment 3 Julien Chaffraix 2012-10-17 15:30:01 PDT
Thanks Eric, this optimization is still valid and would be superseded by bug 89899. I don't have much time to investigate the other bug so let's just land this in the meantime.
Comment 4 Julien Chaffraix 2012-10-17 15:43:48 PDT
Created attachment 169280 [details]
Patch for landing
Comment 5 WebKit Review Bot 2012-10-17 16:33:55 PDT
Comment on attachment 169280 [details]
Patch for landing

Clearing flags on attachment: 169280

Committed r131665: <http://trac.webkit.org/changeset/131665>
Comment 6 WebKit Review Bot 2012-10-17 16:33:59 PDT
All reviewed patches have been landed.  Closing bug.