Bug 89387 - Fix framebuffer-object-attachment.html failures
Summary: Fix framebuffer-object-attachment.html failures
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zhenyao Mo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-18 15:05 PDT by Zhenyao Mo
Modified: 2012-06-18 15:38 PDT (History)
2 users (show)

See Also:

Attachments
Patch (11.00 KB, patch)
2012-06-18 15:15 PDT, Zhenyao Mo 		kbr: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zhenyao Mo 2012-06-18 15:05:17 PDT 
A few bugs

1) in DEPTH_STENCIL_ATTACHMENT we put DEPTH_STENCIL
2) we should always do the re-attachments after removing an attachment buffer (either through framebufferRenderbuffer/framebufferTexture using a null buffer or deleteRenderbuffer/deleteTexture) due to the depth/stencil/depth_stencil conflicts
3) getParameter(DEPTH_BITS/STENCIL_BITS) bug: right now we assume it's always from drawing buffer
Comment 1 Zhenyao Mo 2012-06-18 15:15:32 PDT 
Created attachment 148185 [details]
Patch
Comment 2 Zhenyao Mo 2012-06-18 15:17:47 PDT 
Test change will be added in a separate patch.  This is because likely this patch needs to be merged back to chrome M21, and separating the tests change in another patch will reduce the possibility of conflicts.
Comment 3 Kenneth Russell 2012-06-18 15:24:14 PDT 
Comment on attachment 148185 [details]
Patch

Looks good. I understand that this is being checked in separately from an updated version of the framebuffer-object-attachment.html layout test to make it easier to backport this fix; let's please update that test and its expectations ASAP though. r=me
Comment 4 Zhenyao Mo 2012-06-18 15:38:28 PDT 
Committed r120636: <http://trac.webkit.org/changeset/120636>