Bug 89382 - WTR should be able to load external resources
Summary: WTR should be able to load external resources
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Balazs Kelemen
URL:
Keywords:
Depends on: 93122
Blocks:
  Show dependency tree / graph
 
Reported: 2012-06-18 14:23 PDT by Balazs Kelemen
Modified: 2012-08-06 07:55 PDT (History)
5 users (show)

See Also:

Attachments
Patch (4.27 KB, patch)
2012-06-18 14:35 PDT, Balazs Kelemen 		no flags Details | Formatted Diff | Diff
fixed patch (4.51 KB, patch)
2012-08-06 05:15 PDT, Balazs Kelemen 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Balazs Kelemen 2012-06-18 14:23:38 PDT 
... for performance tests.
Comment 1 Balazs Kelemen 2012-06-18 14:35:21 PDT 
Created attachment 148173 [details]
Patch
Comment 2 Balazs Kelemen 2012-08-02 14:07:45 PDT 
Comment on attachment 148173 [details]
Patch

Going to land tomorrow after a double check.
Comment 3 Balazs Kelemen 2012-08-03 01:19:47 PDT 
Comment on attachment 148173 [details]
Patch

Landed in http://trac.webkit.org/changeset/124567
Comment 4 Csaba Osztrogonác 2012-08-03 07:38:51 PDT 
(In reply to comment #3)
> (From update of attachment 148173 [details])
> Landed in http://trac.webkit.org/changeset/124567

It made 5 tests fail, here is the new bug report for you: https://bugs.webkit.org/show_bug.cgi?id=93122
Comment 5 Balazs Kelemen 2012-08-03 08:50:04 PDT 
Reopening because of the fails.
Comment 6 Balazs Kelemen 2012-08-03 09:05:24 PDT 
Reverted r124567 for reason:

Broke some tests with external resources

Committed r124618: <http://trac.webkit.org/changeset/124618>
Comment 7 Balazs Kelemen 2012-08-03 09:05:49 PDT 
Rolled out in http://trac.webkit.org/changeset/124618
Comment 8 Balazs Kelemen 2012-08-06 05:15:34 PDT 
Created attachment 156667 [details]
fixed patch
Comment 9 Balazs Kelemen 2012-08-06 05:17:30 PDT 
Tests failed last time are fixed, other tests seems ok too.
Comment 10 Balazs Kelemen 2012-08-06 07:55:12 PDT 
Comment on attachment 156667 [details]
fixed patch

Clearing flags on attachment: 156667

Committed r124770: <http://trac.webkit.org/changeset/124770>
Comment 11 Balazs Kelemen 2012-08-06 07:55:17 PDT 
All reviewed patches have been landed.  Closing bug.