[chromium] ContentLayerPainter should clear rect to be painted

[James Robinson]

[chromium] ContentLayerPainter should clear rect to be painted

[James Robinson]

Created attachment 148164 [details]
Patch

[James Robinson]

Created attachment 148165 [details]
remove more redundant clears

[Stephen White]

Comment on attachment 148165 [details]
remove more redundant clears

The skia stuff looks ok, but I'll defer to enne or someone else more compositor-savvy for the rest.

[Stephen White]

Oh, and could we get some test coverage for this?

[Dana Jansens]

Comment on attachment 148165 [details]
remove more redundant clears

View in context: https://bugs.webkit.org/attachment.cgi?id=148165&action=review

> Source/WebCore/platform/graphics/chromium/ScrollbarLayerChromium.cpp:-120
> -        context.clearRect(contentRect);
> -        context.clip(contentRect);

Is the implication that the canvas will now be cleared by the added code in ContentLayerPainter? Cuz I don't see how that can be, or is this being removed for a different reason?

[Adrienne Walker]

Comment on attachment 148165 [details]
remove more redundant clears

View in context: https://bugs.webkit.org/attachment.cgi?id=148165&action=review

> Source/WebCore/platform/graphics/chromium/ContentLayerChromium.cpp:69
> +        SkPaint paint;
> +        paint.setAntiAlias(false);
> +        paint.setXfermodeMode(SkXfermode::kClear_Mode);
> +        canvas->drawRect(contentRect, paint);
> +        canvas->clipRect(contentRect);

I think this should maybe go in CanvasLayerTextureUpdater so that the root and scrollbars get cleared properly, since both of those use different painters other than ContentLayerPainter.

[James Robinson]

D'oh, will move it up.

[James Robinson]

Created attachment 148193 [details]
clear in CanvasLayerTextureUpdater

[Adrienne Walker]

Comment on attachment 148193 [details]
clear in CanvasLayerTextureUpdater

R=me.

[James Robinson]

Committed r120640: <http://trac.webkit.org/changeset/120640>