Bug 89374 (STDINT_H_X64) - stdint.h installed for windows causes errors when compiling with MSVC for x64
Summary: stdint.h installed for windows causes errors when compiling with MSVC for x64
Status: RESOLVED FIXED
Alias: STDINT_H_X64
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Minor
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-18 13:22 PDT by Alex Christensen
Modified: 2012-12-07 11:21 PST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2012-06-18 13:22:57 PDT
When compiling JavaScriptCore for a 64-bit machine with MSVC, WebKitLibraries\win\include\stdint.h causes compile errors.  I suggest lines 56-58 be changed from 

/* 7.18.1.4  Integer types capable of holding object pointers */
typedef int intptr_t;
typedef unsigned uintptr_t;

to this:

/* 7.18.1.4  Integer types capable of holding object pointers */
typedef ptrdiff_t intptr_t;
typedef size_t uintptr_t;

This change works for 32 bit and 64 bit machines.  This is not a part of the repository (it's installed with the script update-webkit --wincairo), so I cannot submit a patch.
Comment 1 Patrick R. Gansterer 2012-08-06 14:44:38 PDT
wincairo should use http://trac.webkit.org/browser/trunk/Source/JavaScriptCore/os-win32/stdint.h instead. If that file does not work, a bug is ok. But for the wincairo files you should talk to Brent in the github repository at https://github.com/bfulgham/WinCairoRequirements, since they are not part of WebKit directly.
Comment 2 Brent Fulgham 2012-12-07 11:21:50 PST
I uploaded a new WinCairoRequirements bundle that addresses this issue.  This isn't a WebKit bug, but rather a build environment problem.

Running "update-webkit --wincairo" should give you the new headers/binaries/link libraries.

Note that I do not provide 64-bit builds in this bundle at present.