Bug 89372 (VSPROPS_SAFESEH) - /SAFESEH should not be a common linker option
Summary: /SAFESEH should not be a common linker option
Status: RESOLVED FIXED
Alias: VSPROPS_SAFESEH
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P3 Minor
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-18 12:53 PDT by Alex Christensen
Modified: 2012-08-14 16:40 PDT (History)
1 user (show)

See Also:

Attachments
Patch (9.97 KB, patch)
2012-06-21 09:36 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2012-06-18 12:53:00 PDT 
The file WebKitLibraries\win\tools\vsprops\common.vsprops has /SAFESEH as an additional linker option.  This does not work with Visual Studio's x64 compiler.  It seems to work without it, but I don't think this is a good solution.  Is there a way to only use it for x86 solutions?
Comment 1 Alex Christensen 2012-06-21 09:36:32 PDT 
Created attachment 148818 [details]
Patch
Comment 2 WebKit Review Bot 2012-08-14 16:40:33 PDT 
Comment on attachment 148818 [details]
Patch

Clearing flags on attachment: 148818

Committed r125622: <http://trac.webkit.org/changeset/125622>
Comment 3 WebKit Review Bot 2012-08-14 16:40:36 PDT 
All reviewed patches have been landed.  Closing bug.